refactor: Remove generic
aria role from types
#4610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec
The language used is pretty weak, ("SHOULD NOT" rather than "MUST NOT"), but the intention is clearly that the
generic
role is only meant for implicit use by user agents, not end users.I've been searching over the past few days and have yet to find a single situation in which
role="generic"
adds any improvement and is recommended over the alternatives (like'presentation'
) but haven't come up with anything. Therefore, I think removal is correct & an improvement to our types. Technically a valid string value but there's no reason why someone should ever set it.