Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove static dom bail #4670

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Remove static dom bail #4670

merged 1 commit into from
Feb 14, 2025

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Feb 14, 2025

This is a highly unusual thing for people to use and when they do it will be very cheap either way. This removes the bail for const x = (<div />. It's only 13 bytes saved but πŸ€·β€β™‚οΈ

Copy link

github-actions bot commented Feb 14, 2025

πŸ“Š Tachometer Benchmark Results

Summary

duration

  • create10k: unsure πŸ” -0% - +1% (-3.89ms - +5.58ms)
    preact-local vs preact-main
  • filter-list: unsure πŸ” -0% - +1% (-0.05ms - +0.11ms)
    preact-local vs preact-main
  • hydrate1k: unsure πŸ” -0% - +2% (-0.37ms - +1.54ms)
    preact-local vs preact-main
  • many-updates: unsure πŸ” -3% - +2% (-0.45ms - +0.29ms)
    preact-local vs preact-main
  • replace1k: unsure πŸ” -2% - +1% (-1.78ms - +0.73ms)
    preact-local vs preact-main
  • text-update: unsure πŸ” -3% - +5% (-0.06ms - +0.10ms)
    preact-local vs preact-main
  • todo: faster βœ” 1% - 4% (0.27ms - 1.56ms)
    preact-local vs preact-main
  • update10th1k: unsure πŸ” -4% - +4% (-1.18ms - +1.14ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure πŸ” -0% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure πŸ” -1% - +2% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure πŸ” -1% - +7% (-0.08ms - +0.67ms)
    preact-local vs preact-main
  • many-updates: unsure πŸ” -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure πŸ” -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure πŸ” -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • todo: unsure πŸ” -2% - +0% (-0.03ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: faster βœ” 0% - 2% (0.01ms - 0.05ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local930.09ms - 937.86ms-unsure πŸ”
-0% - +1%
-3.89ms - +5.58ms
preact-main930.42ms - 935.85msunsure πŸ”
-1% - +0%
-5.58ms - +3.89ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.20ms-unsure πŸ”
-0% - +0%
-0.02ms - +0.00ms
preact-main19.19ms - 19.21msunsure πŸ”
-0% - +0%
-0.00ms - +0.02ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.58ms - 16.72ms-unsure πŸ”
-0% - +1%
-0.05ms - +0.11ms
preact-main16.58ms - 16.67msunsure πŸ”
-1% - +0%
-0.11ms - +0.05ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.52ms - 1.56ms-unsure πŸ”
-1% - +2%
-0.02ms - +0.03ms
preact-main1.52ms - 1.55msunsure πŸ”
-2% - +1%
-0.03ms - +0.02ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local75.53ms - 77.13ms-unsure πŸ”
-0% - +2%
-0.37ms - +1.54ms
preact-main75.22ms - 76.27msunsure πŸ”
-2% - +0%
-1.54ms - +0.37ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.61ms - 10.13ms-unsure πŸ”
-1% - +7%
-0.08ms - +0.67ms
preact-main9.30ms - 9.85msunsure πŸ”
-7% - +1%
-0.67ms - +0.08ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.33ms - 16.79ms-unsure πŸ”
-3% - +2%
-0.45ms - +0.29ms
preact-main16.35ms - 16.93msunsure πŸ”
-2% - +3%
-0.29ms - +0.45ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.76ms - 3.79ms-unsure πŸ”
-0% - +1%
-0.01ms - +0.03ms
preact-main3.76ms - 3.77msunsure πŸ”
-1% - +0%
-0.03ms - +0.01ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4404
  • Commit: 924e669

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.85ms - 71.46ms-unsure πŸ”
-2% - +1%
-1.78ms - +0.73ms
preact-main70.22ms - 72.13msunsure πŸ”
-1% - +3%
-0.73ms - +1.78ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 3.00ms-unsure πŸ”
-0% - +1%
-0.01ms - +0.02ms
preact-main2.97ms - 2.99msunsure πŸ”
-1% - +0%
-0.02ms - +0.01ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local30.10ms - 30.91ms-unsure πŸ”
-3% - +0%
-0.87ms - +0.14ms
preact-main30.57ms - 31.16msunsure πŸ”
-0% - +3%
-0.14ms - +0.87ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.22ms - 35.24ms-unsure πŸ”
-3% - +1%
-0.91ms - +0.37ms
preact-main34.61ms - 35.38msunsure πŸ”
-1% - +3%
-0.37ms - +0.91ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local26.35ms - 26.88ms-unsure πŸ”
-1% - +1%
-0.29ms - +0.35ms
preact-main26.41ms - 26.77msunsure πŸ”
-1% - +1%
-0.35ms - +0.29ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.89ms - 26.97ms-unsure πŸ”
-2% - +4%
-0.54ms - +1.02ms
preact-main25.64ms - 26.75msunsure πŸ”
-4% - +2%
-1.02ms - +0.54ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.06ms - 26.17ms-unsure πŸ”
-4% - +2%
-1.03ms - +0.57ms
preact-main25.27ms - 26.42msunsure πŸ”
-2% - +4%
-0.57ms - +1.03ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.79ms - 21.18ms-unsure πŸ”
-2% - +0%
-0.48ms - +0.10ms
preact-main20.95ms - 21.39msunsure πŸ”
-0% - +2%
-0.10ms - +0.48ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 150
  • Built by: CI #4404
  • Commit: 924e669

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.06ms - 2.18ms-unsure πŸ”
-3% - +5%
-0.06ms - +0.10ms
preact-main2.04ms - 2.15msunsure πŸ”
-5% - +3%
-0.10ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.11ms - 1.12ms-unsure πŸ”
-0% - -0%
-0.00ms - -0.00ms
preact-main1.12ms - 1.12msunsure πŸ”
+0% - +0%
+0.00ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.43ms - 33.70ms-faster βœ”
1% - 4%
0.27ms - 1.56ms
preact-main33.85ms - 35.11msslower ❌
1% - 5%
0.27ms - 1.56ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.25ms-unsure πŸ”
-2% - +0%
-0.03ms - +0.01ms
preact-main1.24ms - 1.26msunsure πŸ”
-0% - +2%
-0.01ms - +0.03ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.54ms - 33.12ms-unsure πŸ”
-4% - +4%
-1.18ms - +1.14ms
preact-main31.50ms - 33.20msunsure πŸ”
-4% - +4%
-1.14ms - +1.18ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.92ms - 2.94ms-faster βœ”
0% - 2%
0.01ms - 0.05ms
preact-main2.94ms - 2.98msslower ❌
0% - 2%
0.01ms - 0.05ms
-

tachometer-reporter-action v2 for CI

Copy link

Size Change: -39 B (-0.08%)

Total Size: 46.3 kB

Filename Size Change
dist/preact.js 4.57 kB -13 B (-0.28%)
dist/preact.mjs 4.59 kB -14 B (-0.3%)
dist/preact.umd.js 4.67 kB -12 B (-0.26%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.69 kB
compat/dist/compat.mjs 3.61 kB
compat/dist/compat.umd.js 3.75 kB
debug/dist/debug.js 3.87 kB
debug/dist/debug.mjs 3.87 kB
debug/dist/debug.umd.js 3.95 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 270 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.55 kB
hooks/dist/hooks.mjs 1.58 kB
hooks/dist/hooks.umd.js 1.62 kB
jsx-runtime/dist/jsxRuntime.js 861 B
jsx-runtime/dist/jsxRuntime.mjs 830 B
jsx-runtime/dist/jsxRuntime.umd.js 934 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit bc839c6 into v11-2 Feb 14, 2025
14 checks passed
@JoviDeCroock JoviDeCroock deleted the remove-static-dom-bail branch February 14, 2025 15:14
JoviDeCroock added a commit that referenced this pull request Feb 18, 2025
JoviDeCroock added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants