Skip to content

fix: Avoid Trusted Types violation when dangerouslySetInnerHTML is re… #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

fix: Avoid Trusted Types violation when dangerouslySetInnerHTML is re… #4935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/diff/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ function diffElementNodes(

newVNode._children = [];
} else {
if (oldHtml) dom.innerHTML = '';
if (oldHtml) dom.textContent = '';
Copy link
Member

@JoviDeCroock JoviDeCroock Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have a test for the trusted HTML case if that's possible at all


if (
nodeType == 'foreignObject' ||
Expand Down
1 change: 1 addition & 0 deletions src/internal.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export interface PreactElement extends preact.ContainerNode {
data?: CharacterData['data'];
// Property to set __dangerouslySetInnerHTML
innerHTML?: Element['innerHTML'];
textContent?: Element['textContent'];
remove?: Element['remove'];

// Attribute reading and setting
Expand Down
Loading