Skip to content

Comments

We should not unmount elements that have effect on styling etc#5029

Open
JoviDeCroock wants to merge 3 commits intov10.xfrom
skip-important-elements
Open

We should not unmount elements that have effect on styling etc#5029
JoviDeCroock wants to merge 3 commits intov10.xfrom
skip-important-elements

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Feb 19, 2026 •
edited
Loading

Relates to preactjs/preact-render-to-string#446

Mounted styles should not get unmounted as we need them on the page so styling persists, I can be swayed the other way for script/link tags.

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: faster ✔ 0% - 1% (0.72ms - 10.33ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.05ms - +0.11ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +0% (-1.64ms - +0.08ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +1% (-0.01ms - +0.08ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +3% (-0.02ms - +1.56ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -6% - +0% (-0.11ms - +0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.28ms - +0.36ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +3% (-1.44ms - +1.15ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +8% (-0.39ms - +0.53ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -2% - +6% (-0.02ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local878.94ms - 886.18ms-faster ✔
0% - 1%
0.72ms - 10.33ms
preact-main884.93ms - 891.25msslower ❌
0% - 1%
0.72ms - 10.33ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.59ms-unsure 🔍
-0% - +1%
-0.05ms - +0.11ms
preact-main16.46ms - 16.62msunsure 🔍
-1% - +0%
-0.11ms - +0.05ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.57ms-unsure 🔍
-0% - +1%
-0.00ms - +0.01ms
preact-main1.55ms - 1.56msunsure 🔍
-1% - +0%
-0.01ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.24ms - 61.43ms-unsure 🔍
-3% - +0%
-1.64ms - +0.08ms
preact-main61.00ms - 62.23msunsure 🔍
-0% - +3%
-0.08ms - +1.64ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.54ms - 7.19ms-unsure 🔍
-6% - +8%
-0.39ms - +0.53ms
preact-main6.47ms - 7.12msunsure 🔍
-8% - +6%
-0.53ms - +0.39ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.62ms-unsure 🔍
-0% - +1%
-0.01ms - +0.08ms
preact-main16.52ms - 16.56msunsure 🔍
-1% - +0%
-0.08ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.71ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5396

  • Commit: 6e73e74

duration

VersionAvg timevs preact-localvs preact-main
preact-local57.31ms - 58.50ms-unsure 🔍
-0% - +3%
-0.02ms - +1.56ms
preact-main56.62ms - 57.66msunsure 🔍
-3% - +0%
-1.56ms - +0.02ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.01ms - 3.01ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main3.01ms - 3.01msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.46ms - 26.15ms-unsure 🔍
-3% - +1%
-0.83ms - +0.15ms
preact-main25.80ms - 26.50msunsure 🔍
-1% - +3%
-0.15ms - +0.83ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.57ms - 32.92ms-unsure 🔍
-2% - +4%
-0.59ms - +1.27ms
preact-main31.27ms - 32.54msunsure 🔍
-4% - +2%
-1.27ms - +0.59ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local31.61ms - 32.78ms-unsure 🔍
-3% - +2%
-1.02ms - +0.59ms
preact-main31.85ms - 32.97msunsure 🔍
-2% - +3%
-0.59ms - +1.02ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.45ms - 25.83ms-unsure 🔍
-1% - +1%
-0.16ms - +0.34ms
preact-main25.39ms - 25.72msunsure 🔍
-1% - +1%
-0.34ms - +0.16ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.90ms - 25.20ms-unsure 🔍
-5% - +2%
-1.30ms - +0.60ms
preact-main24.20ms - 25.58msunsure 🔍
-2% - +5%
-0.60ms - +1.30ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.59ms - 22.08ms-unsure 🔍
-0% - +3%
-0.00ms - +0.64ms
preact-main21.32ms - 21.72msunsure 🔍
-3% - -0%
-0.64ms - +0.00ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 260
  • Built by: CI #5396

  • Commit: 6e73e74

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.74ms - 1.84ms-unsure 🔍
-6% - +0%
-0.11ms - +0.00ms
preact-main1.81ms - 1.88msunsure 🔍
-0% - +6%
-0.00ms - +0.11ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.04ms - 1.10ms-unsure 🔍
-2% - +6%
-0.02ms - +0.06ms
preact-main1.02ms - 1.07msunsure 🔍
-6% - +2%
-0.06ms - +0.02ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.02ms - 33.46ms-unsure 🔍
-1% - +1%
-0.28ms - +0.36ms
preact-main32.97ms - 33.43msunsure 🔍
-1% - +1%
-0.36ms - +0.28ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.25ms-unsure 🔍
+0% - +0%
+0.00ms - +0.00ms
preact-main1.24ms - 1.25msunsure 🔍
-0% - -0%
-0.00ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.19ms - 35.02ms-unsure 🔍
-4% - +3%
-1.44ms - +1.15ms
preact-main33.34ms - 35.16msunsure 🔍
-3% - +4%
-1.15ms - +1.44ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.98ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.97ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Feb 19, 2026 •
edited
Loading

Size Change: +147 B (+0.19%)

Total Size: 78.9 kB

Filename Size Change
dist/preact.js 4.74 kB +22 B (+0.47%)
dist/preact.min.js 4.75 kB +21 B (+0.44%)
dist/preact.min.module.js 4.76 kB +21 B (+0.44%)
dist/preact.min.umd.js 4.77 kB +19 B (+0.4%)
dist/preact.mjs 4.75 kB +22 B (+0.46%)
dist/preact.module.js 4.75 kB +22 B (+0.46%)
dist/preact.umd.js 4.78 kB +20 B (+0.42%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.18 kB
compat/dist/compat.mjs 4.11 kB
compat/dist/compat.module.js 4.11 kB
compat/dist/compat.umd.js 4.25 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.52 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.module.js 1.56 kB
hooks/dist/hooks.umd.js 1.59 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock force-pushed the skip-important-elements branch 3 times, most recently from def087d to 586d8ea Compare February 19, 2026 18:24
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JoviDeCroock