New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback commits on error? #25

Closed

marvinhagemeister opened this issue Aug 16, 2022 · 1 comment

Member

marvinhagemeister commented Aug 16, 2022 •

edited

Loading

Found by @developit :

When a computed errors me might want to roll back the whole commit instead of just the subtree. Doing the latter is fine for now, but ultimately ends up with an inconsistent graph.

Test case: https://gist.github.com/developit/e9d25d6bf38dfbf1ddec13f92b4b3738

An earlier discussion:

when part of the graph bails out due to an error in a computed, re-assigning the value of one of its dependencies doesn't re-run the errored computed - technically correct, since reassignment to the same value shouldn't re-run the graph
I don't think its a bug, but its something we might want to have a doc on.

marvinhagemeister mentioned this issue

Error handling issue #23

Closed

Member Author

marvinhagemeister commented Sep 16, 2022

Fixed by #161

marvinhagemeister closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment