Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement the core without Sets, Maps, etc. #161

Merged
merged 71 commits into from
Sep 16, 2022
Merged

Conversation

jviide
Copy link
Contributor

@jviide jviide commented Sep 16, 2022

This pull request collects together multiple optimizations introduced mainly in #136. Also included are related modifications to the Preact & React integrations, introduced in #156.

This seems to boost (micro)benchmark results quite a bit.
@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2022

🦋 Changeset detected

Latest commit: 6ac6923

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@preact/signals-core Minor
@preact/signals Patch
@preact/signals-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 16, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 6ac6923
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/63248afaa701ce00082ef76a
😎 Deploy Preview https://deploy-preview-161--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

Size Change: +1.5 kB (+2%)

Total Size: 67.5 kB

Filename Size Change
docs/dist/assets/client.********.js 45.8 kB +7 B (0%)
docs/dist/assets/index.********.js 839 B -240 B (-22%) 🎉
docs/dist/assets/signals-core.module.********.js 1.58 kB +596 B (+61%) 🆘
docs/dist/assets/signals.module.********.js 1.96 kB +19 B (+1%)
docs/dist/nesting-********.js 1.13 kB +1 B (0%)
packages/core/dist/signals-core.js 1.64 kB +612 B (+60%) 🆘
packages/core/dist/signals-core.mjs 1.31 kB +485 B (+59%) 🆘
packages/preact/dist/signals.js 1.13 kB +11 B (+1%)
packages/preact/dist/signals.mjs 1.12 kB +4 B (0%)
packages/react/dist/signals.js 834 B +3 B (0%)
packages/react/dist/signals.mjs 797 B +6 B (+1%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B
docs/dist/demos-********.js 3.35 kB
docs/dist/react-********.js 239 B

compressed-size-action

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's happening.gif 🎉 💯

@marvinhagemeister marvinhagemeister merged commit 40e31e8 into main Sep 16, 2022
@marvinhagemeister marvinhagemeister deleted the setless-core branch September 16, 2022 14:44
@github-actions github-actions bot mentioned this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants