Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integrations for "setless" rewrite #156

Merged
merged 7 commits into from
Sep 16, 2022

Conversation

developit
Copy link
Member

@developit developit commented Sep 15, 2022

I've based this off of @jviide's branch so that our size checking and tests run against the whole thing.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: f3c2c19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 8ea2aa9
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6323b166d82ea70008de2b7f
😎 Deploy Preview https://deploy-preview-156--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

Size Change: +1.39 kB (+2%)

Total Size: 67.4 kB

Filename Size Change
docs/dist/assets/client.********.js 45.8 kB +5 B (0%)
docs/dist/assets/index.********.js 1.08 kB +3 B (0%)
docs/dist/assets/signals-core.module.********.js 1.46 kB +475 B (+48%) 🚨
docs/dist/assets/signals.module.********.js 1.96 kB +17 B (+1%)
docs/dist/demos-********.js 3.35 kB +1 B (0%)
docs/dist/nesting-********.js 1.13 kB +1 B (0%)
docs/dist/react-********.js 240 B +1 B (0%)
packages/core/dist/signals-core.js 1.52 kB +495 B (+48%) 🚨
packages/core/dist/signals-core.mjs 1.19 kB +370 B (+45%) 🚨
packages/preact/dist/signals.js 1.13 kB +11 B (+1%)
packages/preact/dist/signals.mjs 1.12 kB +4 B (0%)
packages/react/dist/signals.js 834 B +3 B (0%)
packages/react/dist/signals.mjs 797 B +6 B (+1%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/jsxRuntime.module.********.js 282 B
docs/dist/assets/preact.module.********.js 4 kB
docs/dist/assets/style.********.js 21 B
docs/dist/assets/style.********.css 1.21 kB
docs/dist/basic-********.js 244 B

compressed-size-action

Copy link
Contributor

@jviide jviide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Added tests to the setless branch for Effect internals that this integration code depends on.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marvinhagemeister marvinhagemeister changed the base branch from main to setless-core September 16, 2022 10:43
@marvinhagemeister marvinhagemeister merged commit babcedb into setless-core Sep 16, 2022
@marvinhagemeister marvinhagemeister deleted the setless-integrations branch September 16, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants