Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UMD output of @preact/signals, @preact/signals-react use wrong name for @preact/signals-core #398

Closed
rschristian opened this issue Aug 11, 2023 · 0 comments · Fixed by #399
Closed

UMD output of @preact/signals, @preact/signals-react use wrong name for @preact/signals-core #398

rschristian opened this issue Aug 11, 2023 · 0 comments · Fixed by #399

Comments

@rschristian
Copy link
Member

rschristian commented Aug 11, 2023 •
edited
Loading

@preact/signals-core attaches to window.preactSignalsCore rather predictably, but @preact/signals, @preact/signals-react will search for window.signalsCore. Microbundle takes a guess that the namespace isn't important, such as it wouldn't be in say forks (@rschristian/preact -> preact).

Need to specify the globals is all.
@rschristian rschristian changed the title UMD output of @preact/signals uses wrong name for @preact/signals-core UMD output of @preact/signals, @preact/signals-react use wrong name for @preact/signals-core Aug 11, 2023
@rschristian rschristian mentioned this issue Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Specify @preact/signals-core global to Microbundle preactjs/signals
1 participant
@rschristian