fix: Specify @preact/signals-core global to Microbundle
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 686f9c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rschristian
changed the title
@preact/signals-core global to Microbundle
|
Size Change: 0 B Total Size: 78 kB ℹ️ View Unchanged
|
rschristian
commented
Aug 11, 2023
| "build:react": "microbundle --raw --cwd packages/react && pnpm postbuild:react", | ||
| "build:react-runtime": "microbundle --raw --cwd packages/react/runtime && pnpm postbuild:react-runtime", | ||
| "build:react-transform": "microbundle --no-compress --raw --cwd packages/react-transform", | ||
| "_build": "microbundle --raw --globals @preact/signals-core=preactSignalsCore", |
There was a problem hiding this comment.
Not sure if this is any better tbh; either way I find it to be an unreadable wall of text. At least it reduces the duplication of the --raw and --globals flags? Happy to revert.
JoviDeCroock
approved these changes
Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398