Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement effect cleanups #183

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Implement effect cleanups #183

merged 10 commits into from
Sep 19, 2022

Commits on Sep 19, 2022

  1. Add tests for effect cleanups

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    4340faf View commit details
    Browse the repository at this point in the history

  2. Add effect cleanup tests

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    10bf714 View commit details
    Browse the repository at this point in the history

  3. Add tests for computeds vs. effect cleanup

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    f5148d0 View commit details
    Browse the repository at this point in the history

  4. Implement effect cleanups

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    852b4ce View commit details
    Browse the repository at this point in the history

  5. Implement useSignalEffect with effect cleanups

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    2ab7157 View commit details
    Browse the repository at this point in the history

  6. Rename & reorganize internal core flags

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    9cd08d3 View commit details
    Browse the repository at this point in the history

  7. Add one more effect cleanup test

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    703a900 View commit details
    Browse the repository at this point in the history

  8. Fix in which order an effect ends its implicit batch

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    6bfbf5f View commit details
    Browse the repository at this point in the history

  9. Always run cleanup functions outside of any context

    @jviide
    jviide committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    0f44dc1 View commit details
    Browse the repository at this point in the history

  10. Add changeset

    @marvinhagemeister
    marvinhagemeister authored Sep 19, 2022
    Configuration menu
    Copy the full SHA
    79ff1e7 View commit details
    Browse the repository at this point in the history