-
-
Notifications
You must be signed in to change notification settings - Fork 113
Fix signals aborting context updates #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Size Change: +140 B (0%) Total Size: 68.5 kB
ℹ️ View Unchanged
|
Co-authored-by: Jason Miller <jason@developit.ca>
bc6b9b7
to
5f6f7c7
Compare
Co-authored-by: Matt d'Entremont <mattdentremont@gmail.com>
Managed to narrow the remaining issue to a reproducible test case. |
Closing as the actual source of the problem was a bug in Preact. See preactjs/preact#3889 . |
We noticed that a component that subscribes to a signal may block updates in a scenario where the signal didn't update, but context values did.
Authored together with @developit and @mdentremont in a paring session.