Skip to content

Conversation

JoviDeCroock
Copy link
Member

This introduces an option to always peek so we don't subscribe, the use case for this would be distributive repetitive renderers like render-to-string and prepass.

This currently only affects text optimization but this should probably apply to all of these 😅 another alternative would be to register an option to unsubscribeAll

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2022

⚠️ No Changeset found

Latest commit: 162ed2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit 162ed2d
🔍 Latest deploy log https://app.netlify.com/sites/preact-signals-demo/deploys/6317b65b27576400083828d4
😎 Deploy Preview https://deploy-preview-72--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoviDeCroock JoviDeCroock marked this pull request as draft September 6, 2022 21:06
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Size Change: +69 B (0%)

Total Size: 59.7 kB

Filename Size Change
docs/dist/assets/signals.module.********.js 5.63 kB +22 B (0%)
packages/preact/dist/signals.js 1.09 kB +25 B (+2%)
packages/preact/dist/signals.mjs 1.07 kB +22 B (+2%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/basic.********.js 218 B
docs/dist/assets/client.********.js 45.8 kB
docs/dist/assets/index.********.js 1.06 kB
docs/dist/assets/signals-core.module.********.js 868 B
docs/dist/assets/style.********.css 585 B
packages/core/dist/signals-core.js 1 kB
packages/core/dist/signals-core.mjs 823 B
packages/react/dist/signals.js 798 B
packages/react/dist/signals.mjs 753 B

compressed-size-action

@JoviDeCroock
Copy link
Member Author

Superseded by preactjs/preact-render-to-string#242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant