Proposal: use signal effect #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 183000d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: +431 B (+1%) Total Size: 67.9 kB
ℹ️ View Unchanged
|
developit
reviewed
Sep 10, 2022
packages/preact/src/index.ts
Outdated
| @@ -283,6 +283,15 @@ export function useComputed<T>(compute: () => T) { | |||
| return useMemo(() => computed<T>(() => $compute.current()), []); | |||
| } | |||
|
|
|||
| export function useSignalEffect(cb: () => void) { | |||
There was a problem hiding this comment.
Let's add this hook to the react adapter too 👍
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
JoviDeCroock
force-pushed
the
use-signal-effect
branch
from
af1e4df to
d13a7aa
Compare
marvinhagemeister
approved these changes
Sep 17, 2022
motss
reviewed
Sep 17, 2022
motss
reviewed
Sep 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running effects is a bit of a pitfall imho, or we run them globally outside of the function-scope, or we have to wrap them with a
useMemo/useEffect/... This lead me on the path of creating a small utility function that abstracts this. When people want to use a globalsignal/effectthey can import from thecorepackage, however when they want a component-specific signal they leverageuseSignal. It's here where I saw a discrepancy, we have a utility to help provide a signal but no utility for the effect.Here comes the introduction of
useSignalEffectit basically wraps aneffectwithuseEffectand holds a stable ref to the callback being passed to theuseSignalEffectso we don't have to bother adding dependencies to the array of the useduseEffect. Currently the only short-coming I may be foreseeing is the lack of anonInvalidatefunction, i.e. what happens if an effect updates that is for example still fetching, we could be introducing a race-condition there.Usage: