Fix offEvent function with callback

prebid · Sep 11, 2024 · 08eb3b2 · 08eb3b2
1 parent 431b85e
commit 08eb3b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/modules/adplayerproVideoProvider.js b/modules/adplayerproVideoProvider.js
@@ -169,9 +169,9 @@ export function AdPlayerProProvider(config, adPlayerPro_, callbackStorage_, util
     const playerEventName = utils.getPlayerEvent(event);
     const eventHandler = callbackStorage.getCallback(playerEventName, callback);
     if (eventHandler) {
-      player && player.off(playerEventName);
-    } else {
       player && player.off(playerEventName, eventHandler);
+    } else {
+      player && player.off(playerEventName);
     }
     callbackStorage.clearCallback(playerEventName, callback);
   }

diff --git a/test/spec/modules/videoModule/submodules/adplayerproVideoProvider_spec.js b/test/spec/modules/videoModule/submodules/adplayerproVideoProvider_spec.js
@@ -298,7 +298,9 @@ describe('AdPlayerProProvider', function () {
       provider.offEvent(AD_IMPRESSION, callback);
       expect(offSpy.calledOnce).to.be.true;
       const eventName = offSpy.args[0][0];
+      const eventCallback = offSpy.args[0][1];
       expect(eventName).to.be.equal('AdImpression');
+      expect(eventCallback).to.be.exist;
     });
 
     it('should remove event listener on player by eventName', function () {