update all pixels to use utils.triggerPixel and stub tests

prebid · Jan 6, 2020 · 0c69fed · 0c69fed
1 parent d944d14
commit 0c69fed
Show file tree

Hide file tree

Showing 8 changed files with 46 additions and 21 deletions.
diff --git a/modules/adponeBidAdapter.js b/modules/adponeBidAdapter.js
@@ -1,5 +1,6 @@
 import {BANNER} from '../src/mediaTypes';
 import {registerBidder} from '../src/adapters/bidderFactory';
+import {triggerPixel} from '../src/utils';
 
 const ADPONE_CODE = 'adpone';
 const ADPONE_ENDPOINT = 'https://rtb.adpone.com/bid-request';
@@ -87,8 +88,7 @@ export const spec = {
  onBidWon: bid => {
  const bidString = JSON.stringify(bid);
  const encodedBuf = window.btoa(bidString);
- const img = new Image(1, 1);
- img.src = `https://rtb.adpone.com/prebid/analytics?q=${encodedBuf}`;
+ triggerPixel(`https://rtb.adpone.com/prebid/analytics?q=${encodedBuf}`);
  },
 
 };

diff --git a/modules/mgidBidAdapter.js b/modules/mgidBidAdapter.js
@@ -232,7 +232,7 @@ export const spec = {
  /\${AUCTION_PRICE}/,
  cpm
  );
- pixel(bid.nurl);
+ utils.triggerPixel(bid.nurl);
  }
  if (bid.isBurl) {
  if (bid.mediaType === BANNER) {
@@ -245,7 +245,7 @@ export const spec = {
  /\${AUCTION_PRICE}/,
  cpm
  );
- pixel(bid.burl);
+ utils.triggerPixel(bid.burl);
  }
  }
  utils.logInfo(LOG_INFO_PREFIX + `onBidWon`);
@@ -331,10 +331,6 @@ function extractDomainFromHost(pageHost) {
  return domain;
 }
 
-function pixel(url) {
- (document.createElement('IMG')).src = url;
-}
-
 function getLanguage() {
  const language = navigator.language ? 'language' : 'userLanguage';
  const lang2 = navigator[language].split('-')[0];

diff --git a/modules/videoNowBidAdapter.js b/modules/videoNowBidAdapter.js
@@ -170,10 +170,7 @@ function getUserSyncs(syncOptions, serverResponses) {
 function onBidWon(bid) {
  const { nurl } = bid || {}
  if (nurl) {
- const img = document.createElement('img')
- img.src = utils.replaceAuctionPrice(nurl, bid.cpm)
- img.style.cssText = 'display:none !important;'
- document.body.appendChild(img)
+ utils.triggerPixel(utils.replaceAuctionPrice(nurl, bid.cpm));
  }
 }
 

diff --git a/test/spec/modules/adponeBidAdapter_spec.js b/test/spec/modules/adponeBidAdapter_spec.js
@@ -1,6 +1,7 @@
 import { expect } from 'chai';
 import { spec } from 'modules/adponeBidAdapter';
-import {newBidder} from '../../../src/adapters/bidderFactory';
+import {newBidder} from 'src/adapters/bidderFactory';
+import * as utils from 'src/utils';
 
 const EMPTY_ARRAY = [];
 describe('adponeBidAdapter', function () {
@@ -213,11 +214,18 @@ describe('getUserSyncs', function () {
 });
 
 describe('test onBidWon function', function () {
+ beforeEach(function() {
+ sinon.stub(utils, 'triggerPixel');
+ });
+ afterEach(function() {
+ utils.triggerPixel.restore();
+ });
  it('exists and is a function', () => {
  expect(spec.onBidWon).to.exist.and.to.be.a('function');
  });
  it('should return nothing', function () {
  var response = spec.onBidWon({});
  expect(response).to.be.an('undefined')
+ expect(utils.triggerPixel.called).to.equal(true);
  });
 });
diff --git a/test/spec/modules/emoteevBidAdapter_spec.js b/test/spec/modules/emoteevBidAdapter_spec.js
@@ -736,7 +736,7 @@ describe('emoteevBidAdapter', function () {
  });
 
  describe('side effects', function () {
- let triggerPixelSpy;
+ let triggerPixelStub;
  let getCookieSpy;
  let getConfigSpy;
  let getParameterByNameSpy;
@@ -748,13 +748,13 @@ describe('emoteevBidAdapter', function () {
  config.resetConfig();
  });
  beforeEach(function () {
- triggerPixelSpy = sinon.spy(utils, 'triggerPixel');
+ triggerPixelStub = sinon.stub(utils, 'triggerPixel');
  getCookieSpy = sinon.spy(utils, 'getCookie');
  getConfigSpy = sinon.spy(config, 'getConfig');
  getParameterByNameSpy = sinon.spy(utils, 'getParameterByName');
  });
  afterEach(function () {
- triggerPixelSpy.restore();
+ triggerPixelStub.restore();
  getCookieSpy.restore();
  getConfigSpy.restore();
  getParameterByNameSpy.restore();

diff --git a/test/spec/modules/mgidBidAdapter_spec.js b/test/spec/modules/mgidBidAdapter_spec.js
@@ -676,6 +676,12 @@ describe('Mgid bid adapter', function () {
  });
  });
  describe('on bidWon', function () {
+ beforeEach(function() {
+ sinon.stub(utils, 'triggerPixel');
+ });
+ afterEach(function() {
+ utils.triggerPixel.restore();
+ });
  it('should replace nurl and burl for native', function () {
  const burl = 'burl&s=${' + 'AUCTION_PRICE}';
  const nurl = 'nurl&s=${' + 'AUCTION_PRICE}';

diff --git a/test/spec/modules/telariaBidAdapter_spec.js b/test/spec/modules/telariaBidAdapter_spec.js
@@ -1,6 +1,7 @@
 import {expect} from 'chai';
 import {newBidder} from 'src/adapters/bidderFactory';
 import {spec, getTimeoutUrl} from 'modules/telariaBidAdapter';
+import * as utils from 'src/utils';
 
 const ENDPOINT = '.ads.tremorhub.com/ad/tag';
 const AD_CODE = 'ssp-!demo!-lufip';
@@ -269,13 +270,22 @@ describe('TelariaAdapter', () => {
  }]
  }];
 
+ beforeEach(function() {
+ sinon.stub(utils, 'triggerPixel');
+ });
+
+ afterEach(function() {
+ utils.triggerPixel.restore();
+ });
+
  it('should return a pixel url', () => {
  let url = getTimeoutUrl(timeoutData);
  assert(url);
  });
 
  it('should fire a pixel', () => {
  expect(spec.onTimeout(timeoutData)).to.be.undefined;
+ expect(utils.triggerPixel.called).to.equal(true);
  });
  });
 });
diff --git a/test/spec/modules/videoNowBidAdapter_spec.js b/test/spec/modules/videoNowBidAdapter_spec.js
@@ -1,6 +1,7 @@
 import { expect } from 'chai'
 import { spec } from 'modules/videoNowBidAdapter'
-import { replaceAuctionPrice } from '../../../src/utils'
+import { replaceAuctionPrice } from 'src/utils'
+import * as utils from 'src/utils';
 
 // childNode.remove polyfill for ie11
 // suggested by: https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove
@@ -260,21 +261,28 @@ describe('videonowAdapterTests', function() {
  const cpm = 10
  const nurl = 'https://fakedomain.nld?price=${AUCTION_PRICE}'
  const imgSrc = replaceAuctionPrice(nurl, cpm)
- const foundPixels = () => window.document.body.querySelectorAll(`img[src="${imgSrc}"]`)
+
+ beforeEach(function() {
+ sinon.stub(utils, 'triggerPixel')
+ })
+
+ afterEach(function() {
+ utils.triggerPixel.restore()
+ })
 
  it('Should not create nurl pixel if bid is undefined', function() {
  spec.onBidWon()
- expect(foundPixels().length).to.equal(0)
+ expect(utils.triggerPixel.called).to.equal(false);
  })
 
  it('Should not create nurl pixel if bid does not contains nurl', function() {
  spec.onBidWon({})
- expect(foundPixels().length).to.equal(0)
+ expect(utils.triggerPixel.called).to.equal(false);
  })
 
  it('Should create nurl pixel if bid nurl', function() {
  spec.onBidWon({ nurl, cpm })
- expect(foundPixels().length).to.equal(1)
+ expect(utils.triggerPixel.calledWith(imgSrc)).to.equal(true);
  })
  })