Rubicon project fix remove ad unit iteration (#535)

* iterate over adUnits backwards to prevent errors with in-place array mutation * add unit test for removeAdUnit
prebid · Aug 20, 2016 · 1285731 · 1285731
1 parent e4e4f67
commit 1285731
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/src/prebid.js b/src/prebid.js
@@ -482,7 +482,7 @@ $$PREBID_GLOBAL$$.renderAd = function (doc, id) {
 $$PREBID_GLOBAL$$.removeAdUnit = function (adUnitCode) {
   utils.logInfo('Invoking $$PREBID_GLOBAL$$.removeAdUnit', arguments);
   if (adUnitCode) {
-    for (var i = 0; i < $$PREBID_GLOBAL$$.adUnits.length; i++) {
+    for (var i = $$PREBID_GLOBAL$$.adUnits.length - 1; i >= 0; i--) {
       if ($$PREBID_GLOBAL$$.adUnits[i].code === adUnitCode) {
         $$PREBID_GLOBAL$$.adUnits.splice(i, 1);
       }

diff --git a/test/spec/unit/pbjs_api_spec.js b/test/spec/unit/pbjs_api_spec.js
@@ -834,4 +834,34 @@ describe('Unit: Prebid Module', function () {
       $$PREBID_GLOBAL$$._winningBids = [];
     });
   });
+
+  describe('removeAdUnit', () => {
+    it('should remove given adUnit in adUnits array', () => {
+      const adUnit1 = {
+        code: 'adUnit1',
+        bids: [{
+          bidder: 'appnexus',
+          params: { placementId: '123' }
+        }]
+      };
+      const adUnit2 = {
+        code: 'adUnit2',
+        bids: [{
+          bidder: 'rubicon',
+          params: {
+            accountId: "1234",
+            siteId: "1234",
+            zoneId: "1234"
+          }
+        }]
+      };
+      const adUnits = [adUnit1, adUnit2];
+      $$PREBID_GLOBAL$$.adUnits = adUnits;
+      $$PREBID_GLOBAL$$.removeAdUnit('foobar');
+      assert.deepEqual($$PREBID_GLOBAL$$.adUnits, adUnits);
+      $$PREBID_GLOBAL$$.removeAdUnit('adUnit1');
+      assert.deepEqual($$PREBID_GLOBAL$$.adUnits, [adUnit2]);
+
+    });
+  });
 });