Skip to content

Commit

Permalink
Do not require API for video requests (#10895)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertrmartinez authored Jan 3, 2024
1 parent 49904a0 commit 136f0bb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
3 changes: 1 addition & 2 deletions modules/rubiconBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -1183,8 +1183,7 @@ export function hasValidVideoParams(bid) {
var requiredParams = {
mimes: arrayType,
protocols: arrayType,
linearity: numberType,
api: arrayType
linearity: numberType
}
// loop through each param and verify it has the correct
Object.keys(requiredParams).forEach(function(param) {
Expand Down
10 changes: 0 additions & 10 deletions test/spec/modules/rubiconBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2381,16 +2381,6 @@ describe('the rubicon adapter', function () {
bidderRequest = createVideoBidderRequest();
delete bidderRequest.bids[0].mediaTypes.video.linearity;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// change api to an string, no good
bidderRequest = createVideoBidderRequest();
bidderRequest.bids[0].mediaTypes.video.api = 'string';
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);

// delete api, no good
bidderRequest = createVideoBidderRequest();
delete bidderRequest.bids[0].mediaTypes.video.api;
expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false);
});

it('bid request is valid when video context is outstream', function () {
Expand Down

0 comments on commit 136f0bb

Please sign in to comment.