Skip to content

Commit

Permalink
Magnite pass along networkId (#9193)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertrmartinez committed Nov 3, 2022
1 parent b762241 commit 41f3e05
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
7 changes: 6 additions & 1 deletion modules/magniteAnalyticsAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,14 @@ export const parseBidResponse = (bid, previousBidResponse) => {
const validAdomains = Array.isArray(adomains) && adomains.filter(domain => typeof domain === 'string');
return validAdomains && validAdomains.length > 0 ? validAdomains.slice(0, 10) : undefined
},
'networkId', () => {
const networkId = deepAccess(bid, 'meta.networkId');
// if not a valid after this, set to undefined so it gets filtered out
return (networkId && networkId.toString()) || undefined;
},
'conversionError', conversionError => conversionError === true || undefined, // only pass if exactly true
'ogCurrency',
'ogPrice'
'ogPrice',
]);
}

Expand Down
26 changes: 26 additions & 0 deletions test/spec/modules/magniteAnalyticsAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,32 @@ describe('magnite analytics adapter', function () {
let message = JSON.parse(server.requests[0].requestBody);
expect(message.auctions[0].adUnits[0].bids[0].bidResponse.adomains).to.deep.equal(test.expected);
});

// Network Id tests
[
{ input: 'magnite.com', expected: 'magnite.com' },
{ input: 12345, expected: '12345' },
{ input: ['magnite.com', 12345], expected: 'magnite.com,12345' }
].forEach((test, index) => {
it(`should handle networkId correctly - #${index + 1}`, function () {
events.emit(AUCTION_INIT, MOCK.AUCTION_INIT);
events.emit(BID_REQUESTED, MOCK.BID_REQUESTED);

let bidResponse = utils.deepClone(MOCK.BID_RESPONSE);
bidResponse.meta = {
networkId: test.input
};

events.emit(BID_RESPONSE, bidResponse);
events.emit(BIDDER_DONE, MOCK.BIDDER_DONE);
events.emit(AUCTION_END, MOCK.AUCTION_END);
events.emit(BID_WON, MOCK.BID_WON);
clock.tick(rubiConf.analyticsBatchTimeout + 1000);

let message = JSON.parse(server.requests[0].requestBody);
expect(message.auctions[0].adUnits[0].bids[0].bidResponse.networkId).to.equal(test.expected);
});
});
});

describe('with session handling', function () {
Expand Down

0 comments on commit 41f3e05

Please sign in to comment.