Skip to content

Commit

Permalink
don't set bidderCode in adapter anymore for rubicon
Browse files Browse the repository at this point in the history
  • Loading branch information
snapwich committed Oct 30, 2017
1 parent c826a93 commit 5938798
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion modules/rubiconBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ export const spec = {
requestId: bidRequest.bidId,
currency: 'USD',
creative_id: ad.creative_id,
bidderCode: spec.code,
cpm: ad.cpm || 0,
dealId: ad.deal
};
Expand Down
3 changes: 0 additions & 3 deletions test/spec/modules/rubiconBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ describe('the rubicon adapter', () => {

expect(bids).to.be.lengthOf(2);

expect(bids[0].bidderCode).to.equal('rubicon');
expect(bids[0].width).to.equal(320);
expect(bids[0].height).to.equal(50);
expect(bids[0].cpm).to.equal(0.911);
Expand All @@ -622,7 +621,6 @@ describe('the rubicon adapter', () => {
expect(bids[0].rubiconTargeting.rpfl_elemid).to.equal('/19968336/header-bid-tag-0');
expect(bids[0].rubiconTargeting.rpfl_14062).to.equal('43_tier_all_test');

expect(bids[1].bidderCode).to.equal('rubicon');
expect(bids[1].width).to.equal(300);
expect(bids[1].height).to.equal(250);
expect(bids[1].cpm).to.equal(0.811);
Expand Down Expand Up @@ -758,7 +756,6 @@ describe('the rubicon adapter', () => {

expect(bids).to.be.lengthOf(1);

expect(bids[0].bidderCode).to.equal('rubicon');
expect(bids[0].creative_id).to.equal('crid-999999');
expect(bids[0].cpm).to.equal(1);
expect(bids[0].descriptionUrl).to.equal('a40fe16e-d08d-46a9-869d-2e1573599e0c');
Expand Down

0 comments on commit 5938798

Please sign in to comment.