Skip to content

Commit

Permalink
VIS.X: remove bidderCode from bidResponse (#5313)
Browse files Browse the repository at this point in the history
  • Loading branch information
mk0x9 authored May 29, 2020
1 parent 9388a0d commit 6288944
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion modules/visxBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ function _addBidResponse(serverBid, bidsMap, currency, bidResponses, bidsWithout
const bid = slot.bids.shift();
bidResponses.push({
requestId: bid.bidId,
bidderCode: spec.code,
cpm: serverBid.price,
width: serverBid.w,
height: serverBid.h,
Expand Down
12 changes: 0 additions & 12 deletions test/spec/modules/visxBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 1</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand Down Expand Up @@ -339,7 +338,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 1</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -352,7 +350,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 600,
'ad': '<div>test content 2</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -365,7 +362,6 @@ describe('VisxAdapter', function () {
'width': 728,
'height': 90,
'ad': '<div>test content 3</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand Down Expand Up @@ -401,7 +397,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 1</div>',
'bidderCode': 'visx',
'currency': 'PLN',
'netRevenue': true,
'ttl': 360,
Expand Down Expand Up @@ -531,7 +526,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 1</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -544,7 +538,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 600,
'ad': '<div>test content 2</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -557,7 +550,6 @@ describe('VisxAdapter', function () {
'width': 728,
'height': 90,
'ad': '<div>test content 3</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -570,7 +562,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 600,
'ad': '<div>test content 4</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -583,7 +574,6 @@ describe('VisxAdapter', function () {
'width': 350,
'height': 600,
'ad': '<div>test content 5</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand Down Expand Up @@ -644,7 +634,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 1</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand All @@ -657,7 +646,6 @@ describe('VisxAdapter', function () {
'width': 300,
'height': 250,
'ad': '<div>test content 2</div>',
'bidderCode': 'visx',
'currency': 'EUR',
'netRevenue': true,
'ttl': 360,
Expand Down

0 comments on commit 6288944

Please sign in to comment.