Skip to content

Commit

Permalink
Sonobi Adapter creativeId support (#2584)
Browse files Browse the repository at this point in the history
* return null from buildRequests if there is no keymakers

* fixed issue where isEmpty was being called from old utils var. Changed test port expectations to the original 9876 port

* Adding creativeId support

* removed duplicate check for empty keymaker data
  • Loading branch information
bansawbanchee authored and jaiminpanchal27 committed May 24, 2018
1 parent 2a6e5f4 commit 7570a6b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/sonobiBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const spec = {
height: Number(height),
ad: createCreative(bidResponse.sbi_dc, bid.sbi_aid),
ttl: 500,
creativeId: bid.sbi_aid,
creativeId: bid.sbi_crid || bid.sbi_aid,
netRevenue: true,
currency: 'USD'
};
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/sonobiBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ describe('SonobiBidAdapter', () => {
'/7780971/sparks_prebid_LB|30b31c1838de1f': {
'sbi_size': '300x600',
'sbi_apoc': 'remnant',
'sbi_crid': '1234abcd',
'sbi_aid': '30292e432662bd5f86d90774b944b039',
'sbi_mouse': 1.07,
},
Expand Down Expand Up @@ -268,7 +269,7 @@ describe('SonobiBidAdapter', () => {
'height': 600,
'ad': '<script type="text/javascript" src="https://mco-1-apex.go.sonobi.com/sbi.js?aid=30292e432662bd5f86d90774b944b039&as=null&ref=localhost:9876"></script>',
'ttl': 500,
'creativeId': '30292e432662bd5f86d90774b944b039',
'creativeId': '1234abcd',
'netRevenue': true,
'currency': 'USD'
},
Expand Down

0 comments on commit 7570a6b

Please sign in to comment.