Skip to content

Commit

Permalink
Revert "sending bid placement slot to trion url to be utilized by our…
Browse files Browse the repository at this point in the history
… endpoint. also utilizing prebid location util function for location"

This reverts commit 2bab824.
  • Loading branch information
Mike Groh committed May 31, 2017
1 parent 2bab824 commit 7786302
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 2 additions & 3 deletions src/adapters/trion.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,16 @@ TrionAdapter = function TrionAdapter() {
var pubId = utils.getBidIdParameter('pubId', bid.params);
var sectionId = utils.getBidIdParameter('sectionId', bid.params);
var re = utils.getBidIdParameter('re', bid.params);
var url = utils.getTopWindowUrl();
var url = window.location.href;
var sizes = utils.parseSizesInput(bid.sizes).join(',');

var trionUrl = BID_REQUEST_BASE_URL;

trionUrl = utils.tryAppendQueryString(trionUrl, 'callback', '$$PREBID_GLOBAL$$.handleTrionCB');
trionUrl = utils.tryAppendQueryString(trionUrl, 'callback', 'pbjs.handleTrionCB');
trionUrl = utils.tryAppendQueryString(trionUrl, 'bidId', bidId);
trionUrl = utils.tryAppendQueryString(trionUrl, 'pubId', pubId);
trionUrl = utils.tryAppendQueryString(trionUrl, 'sectionId', sectionId);
trionUrl = utils.tryAppendQueryString(trionUrl, 're', re);
trionUrl = utils.tryAppendQueryString(trionUrl, 'slot', bid.placementCode);
if (url) {
trionUrl += 'url=' + url + '&';
}
Expand Down
4 changes: 1 addition & 3 deletions test/spec/adapters/trion_spec.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { expect } from 'chai';
import trionAdapter from 'src/adapters/trion';
import bidmanager from 'src/bidmanager';
import * as utils from 'src/utils';
const CONSTANTS = require('src/constants.json');
const adloader = require('src/adloader');

Expand Down Expand Up @@ -108,8 +107,7 @@ describe('Trion adapter tests', () => {

let bidUrl = spyLoadScript.getCall(0).args[0];
expect(bidUrl).to.include('re=1');
expect(bidUrl).to.include(utils.getTopWindowUrl());
expect(bidUrl).to.include('slot=' + PLACEMENT_CODE);
expect(bidUrl).to.include(window.location.href);
delete params.re;
});

Expand Down

0 comments on commit 7786302

Please sign in to comment.