Skip to content

Commit

Permalink
Added automatic tzo and targetId to adserver request. (#6534)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikael-lundin authored Apr 7, 2021
1 parent 81fc1ce commit 987c082
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
11 changes: 6 additions & 5 deletions modules/adnuntiusBidAdapter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

import { registerBidder } from '../src/adapters/bidderFactory.js';
const BIDDER_CODE = 'adnuntius';
const ENDPOINT_URL = 'https://delivery.adnuntius.com/i?tzo=-60&format=json';
const ENDPOINT_URL = 'https://delivery.adnuntius.com/i?tzo=';

export const spec = {
code: BIDDER_CODE,
Expand All @@ -14,6 +14,7 @@ export const spec = {
const networks = {};
const bidRequests = {};
const requests = [];
const tzo = new Date().getTimezoneOffset();

for (var i = 0; i < validBidRequests.length; i++) {
const bid = validBidRequests[i]
Expand All @@ -23,15 +24,15 @@ export const spec = {

networks[network] = networks[network] || {};
networks[network].adUnits = networks[network].adUnits || [];
networks[network].adUnits.push({ ...bid.params.targeting, auId: bid.params.auId });
networks[network].adUnits.push({ ...bid.params.targeting, auId: bid.params.auId, targetId: bid.bidId });
}

const networkKeys = Object.keys(networks)
for (var j = 0; j < networkKeys.length; j++) {
const network = networkKeys[j];
requests.push({
method: 'POST',
url: ENDPOINT_URL,
url: ENDPOINT_URL + tzo + '&format=json',
data: JSON.stringify(networks[network]),
bid: bidRequests[network]
});
Expand All @@ -50,11 +51,11 @@ export const spec = {
const bid = adUnit.ads[0];
bidResponses.push({
requestId: bidRequest.bid[k].bidId,
cpm: (bid.cpm) ? bid.cpm.amount : 0,
cpm: (bid.bid) ? bid.bid.amount : 0,
width: Number(bid.creativeWidth),
height: Number(bid.creativeHeight),
creativeId: bid.creativeId,
currency: (bid.cpm) ? bid.cpm.currency : 'EUR',
currency: (bid.bid) ? bid.bid.currency : 'EUR',
netRevenue: false,
ttl: 360,
ad: adUnit.html
Expand Down
9 changes: 5 additions & 4 deletions test/spec/modules/adnuntiusBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { spec } from 'modules/adnuntiusBidAdapter.js';
import { newBidder } from 'src/adapters/bidderFactory.js';

describe('adnuntiusBidAdapter', function () {
const ENDPOINT_URL = 'https://delivery.adnuntius.com/i?tzo=-60&format=json';
const tzo = new Date().getTimezoneOffset();
const ENDPOINT_URL = `https://delivery.adnuntius.com/i?tzo=${tzo}&format=json`;
const adapter = newBidder(spec);
const bidRequests = [
{
Expand Down Expand Up @@ -47,8 +48,8 @@ describe('adnuntiusBidAdapter', function () {
'destination': 'http://google.com'
},
'cpm': { 'amount': 5.0, 'currency': 'NOK' },
'bid': { 'amount': 0.005, 'currency': 'NOK' },
'cost': { 'amount': 0.005, 'currency': 'NOK' },
'bid': { 'amount': 5.0, 'currency': 'NOK' },
'cost': { 'amount': 5.0, 'currency': 'NOK' },
'impressionTrackingUrls': [],
'impressionTrackingUrlsEsc': [],
'adId': 'adn-id-1347343135',
Expand Down Expand Up @@ -96,7 +97,7 @@ describe('adnuntiusBidAdapter', function () {
expect(request[0]).to.have.property('url');
expect(request[0].url).to.equal(ENDPOINT_URL);
expect(request[0]).to.have.property('data');
expect(request[0].data).to.equal('{\"adUnits\":[{\"auId\":\"8b6bc\"}]}');
expect(request[0].data).to.equal('{\"adUnits\":[{\"auId\":\"8b6bc\",\"targetId\":\"123\"}]}');
});
});

Expand Down

0 comments on commit 987c082

Please sign in to comment.