Skip to content

Commit

Permalink
Criteo: fix creativeId with correct value (#7205)
Browse files Browse the repository at this point in the history
  • Loading branch information
dzhang-criteo authored Jul 22, 2021
1 parent b4c2552 commit a3232ea
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion modules/criteoBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const spec = {
currency: slot.currency,
netRevenue: true,
ttl: slot.ttl || 60,
creativeId: bidId,
creativeId: slot.creativecode,
width: slot.width,
height: slot.height,
dealId: slot.dealCode,
Expand Down
2 changes: 2 additions & 0 deletions test/spec/modules/criteoBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -923,6 +923,7 @@ describe('The Criteo bidding adapter', function () {
impid: 'test-requestId',
cpm: 1.23,
creative: 'test-ad',
creativecode: 'test-crId',
width: 728,
height: 90,
dealCode: 'myDealCode',
Expand All @@ -944,6 +945,7 @@ describe('The Criteo bidding adapter', function () {
expect(bids[0].requestId).to.equal('test-bidId');
expect(bids[0].cpm).to.equal(1.23);
expect(bids[0].ad).to.equal('test-ad');
expect(bids[0].creativeId).to.equal('test-crId');
expect(bids[0].width).to.equal(728);
expect(bids[0].height).to.equal(90);
expect(bids[0].dealId).to.equal('myDealCode');
Expand Down

0 comments on commit a3232ea

Please sign in to comment.