Skip to content

Commit

Permalink
userSync is off by default (#1543)
Browse files Browse the repository at this point in the history
* userSync is off by default

* updating test for userSync off by default
  • Loading branch information
bretg authored and snapwich committed Aug 29, 2017
1 parent 1d3d26b commit c63673c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion modules/rubiconBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ function syncEmily(hasSynced) {
}

const defaultUserSyncConfig = {
enabled: true,
enabled: false,
delay: 5000
};
const iframeUrl = 'https://tap-secure.rubiconproject.com/partner/scripts/rubicon/emily.html?rtb_ext=1';
Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/rubiconBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ describe('the rubicon adapter', () => {
window.$$PREBID_GLOBAL$$.getConfig = origGetConfig;
});

it('should add the Emily iframe by default', () => {
it('should not add the Emily iframe by default', () => {
sinon.stub(window.$$PREBID_GLOBAL$$, 'getConfig', (key) => {
var config = { rubicon: {
userSync: {delay: 10}
Expand All @@ -1116,10 +1116,10 @@ describe('the rubicon adapter', () => {
clock.tick(9);
let iframes = document.querySelectorAll('[src="' + emilyUrl + '"]');
expect(iframes.length).to.equal(0);
// move clock to usersync delay, iframe should have been added
// move clock to usersync delay, iframe should still not have been added
clock.tick(1);
iframes = document.querySelectorAll('[src="' + emilyUrl + '"]');
expect(iframes.length).to.equal(1);
expect(iframes.length).to.equal(0);
});

it('should add the Emily iframe when enabled', () => {
Expand Down

0 comments on commit c63673c

Please sign in to comment.