review fixes

prebid · Aug 14, 2024 · cb790fb · cb790fb
1 parent 6c905bc
commit cb790fb
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 19 deletions.
diff --git a/libraries/ortb2Utils/currency.js b/libraries/ortb2Utils/currency.js
@@ -1,15 +1,3 @@
-const additionalData = new WeakMap();
-
 export function getCurrencyFromBidderRequest(bidderRequest) {
- return (bidderRequest?.ortb2?.ext?.cur || [])[0];
-}
-
-export function setAdditionalData(obj, key, value) {
- const prevValue = additionalData.get(obj) || {};
- additionalData.set(obj, { ...prevValue, [key]: value });
-}
-
-export function getAdditionalData(obj, key) {
- const data = additionalData.get(obj) || {};
- return data[key];
+ return bidderRequest?.ortb2?.ext?.prebid?.adServerCurrency;
 }
diff --git a/modules/currency.js b/modules/currency.js
@@ -341,7 +341,7 @@ registerOrtbProcessor({type: REQUEST, name: 'currency', fn: setOrtbCurrency, pri
 
 function enrichFPDHook(next, fpd) {
  return next(fpd.then(ortb2 => {
- deepSetValue(ortb2, 'ext.cur', [adServerCurrency]);
+ deepSetValue(ortb2, 'ext.prebid.adServerCurrency', adServerCurrency);
  return ortb2;
  }))
 }
diff --git a/modules/koblerBidAdapter.js b/modules/koblerBidAdapter.js
@@ -10,7 +10,19 @@ import {
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER} from '../src/mediaTypes.js';
 import {getRefererInfo} from '../src/refererDetection.js';
-import { getAdditionalData, getCurrencyFromBidderRequest, setAdditionalData } from '../libraries/ortb2Utils/currency.js';
+import { getCurrencyFromBidderRequest } from '../libraries/ortb2Utils/currency.js';
+
+const additionalData = new WeakMap();
+
+export function setAdditionalData(obj, key, value) {
+ const prevValue = additionalData.get(obj) || {};
+ additionalData.set(obj, { ...prevValue, [key]: value });
+}
+
+export function getAdditionalData(obj, key) {
+ const data = additionalData.get(obj) || {};
+ return data[key];
+}
 
 const BIDDER_CODE = 'kobler';
 const BIDDER_ENDPOINT = 'https://bid.essrtb.com/bid/prebid_rtb_call';

diff --git a/test/spec/modules/adgenerationBidAdapter_spec.js b/test/spec/modules/adgenerationBidAdapter_spec.js
@@ -262,7 +262,7 @@ describe('AdgenerationAdapter', function () {
  const bidRequests = {
  banner: {
  bidderRequest: {
- ortb2: { ext: { cur: ['JPY'] } }
+ ortb2: {ext: {prebid: {adServerCurrency: 'JPY'}}}
  },
  bidRequest: {
  bidder: 'adg',
@@ -279,7 +279,7 @@ describe('AdgenerationAdapter', function () {
  },
  native: {
  bidderRequest: {
- ortb2: { ext: { cur: ['JPY'] } }
+ ortb2: {ext: {prebid: {adServerCurrency: 'JPY'}}}
  },
  bidRequest: {
  bidder: 'adg',
@@ -319,7 +319,7 @@ describe('AdgenerationAdapter', function () {
  },
  upperBillboard: {
  bidderRequest: {
- ortb2: { ext: { cur: ['JPY'] } }
+ ortb2: {ext: {prebid: {adServerCurrency: 'JPY'}}}
  },
  bidRequest: {
  bidder: 'adg',

diff --git a/test/spec/modules/currency_spec.js b/test/spec/modules/currency_spec.js
@@ -532,7 +532,7 @@ describe('currency', function () {
  fakeCurrencyFileServer.respondWith(JSON.stringify(getCurrencyRates()));
  setConfig({ adServerCurrency: 'EUR' });
  return fpd({}).then((ortb) => {
- expect(ortb.ext.cur).to.eql(['EUR'])
+ expect(ortb.ext.prebid.adServerCurrency).to.eql('EUR')
  })
  })
  })