Skip to content

Commit

Permalink
convert bidders: missena
Browse files Browse the repository at this point in the history
  • Loading branch information
dgirardi committed May 20, 2022
1 parent d0703d4 commit e6bd48c
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
5 changes: 3 additions & 2 deletions modules/minutemediaBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,9 @@ function generateGeneralParams(generalObject, bidderRequest) {
}

if (bidderRequest && bidderRequest.refererInfo) {
generalParams.referrer = deepAccess(bidderRequest, 'refererInfo.referer');
generalParams.page_url = config.getConfig('pageUrl') || deepAccess(window, 'location.href');
// TODO: are these the right refererInfo values - does the fallback make sense?
generalParams.ref = deepAccess(bidderRequest, 'refererInfo.ref');
generalParams.page_url = deepAccess(bidderRequest, 'refererInfo.page') || window.location.href
}

return generalParams
Expand Down
3 changes: 2 additions & 1 deletion modules/missenaBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export const spec = {
};

if (bidderRequest && bidderRequest.refererInfo) {
payload.referer = bidderRequest.refererInfo.referer;
// TODO: is 'topmostLocation' the right value here?
payload.referer = bidderRequest.refererInfo.topmostLocation;
payload.referer_canonical = bidderRequest.refererInfo.canonicalUrl;
}

Expand Down
1 change: 1 addition & 0 deletions modules/my6senseBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ function isBidRequestValid(bid) {
}

function getUrl(url) {
// TODO: this should probably look at refererInfo
if (!url) {
url = window.location.href;// "clean" url of current web page
}
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/missenaBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('Missena Adapter', function () {
gdprApplies: true,
},
refererInfo: {
referer: 'https://referer',
topmostLocation: 'https://referer',
canonicalUrl: 'https://canonical',
},
};
Expand Down

0 comments on commit e6bd48c

Please sign in to comment.