Inject sessionStorage during testing - Firefox won't allow stubbing t…

…he real one
prebid · Dec 3, 2021 · f112343 · f112343
1 parent 9180a92
commit f112343
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/src/debugging.js b/src/debugging.js
@@ -142,23 +142,21 @@ export function addBidderRequestsHook(next, bidderRequests) {
   next(includedBidderRequests);
 }
 
-export function getConfig(debugging) {
+export function getConfig(debugging, {sessionStorage = window.sessionStorage} = {}) {
   if (!debugging.enabled) {
     disableOverrides();
     try {
-      window.sessionStorage.removeItem(OVERRIDE_KEY);
-    } catch (e) {
-    }
+      sessionStorage.removeItem(OVERRIDE_KEY);
+    } catch (e) {}
   } else {
     try {
       const intKey = bidInterceptor.KEYS.rules;
       const config = deepClone(debugging);
       if (config[intKey]) {
         config[intKey] = bidInterceptor.serializeConfig(config[intKey]);
       }
-      window.sessionStorage.setItem(OVERRIDE_KEY, JSON.stringify(config));
-    } catch (e) {
-    }
+      sessionStorage.setItem(OVERRIDE_KEY, JSON.stringify(config));
+    } catch (e) {}
     enableOverrides(debugging);
   }
 }

diff --git a/test/spec/debugging_spec.js b/test/spec/debugging_spec.js
@@ -69,14 +69,14 @@ describe('Debugging', function () {
           const config = 'raw';
           const result = 'serialized';
           sandbox.stub(BidInterceptor.prototype, 'serializeConfig').returns(result);
-          sandbox.stub(window.sessionStorage, 'setItem');
+          const mockSS = {setItem: sinon.spy()};
           sandbox.stub(BidInterceptor.prototype, 'updateConfig');
           getConfig({
             enabled: true,
-            [interceptorConfigKey]: config
-          });
+            [interceptorConfigKey]: config,
+          }, {sessionStorage: mockSS});
           expect(BidInterceptor.prototype.serializeConfig.calledWith(config)).to.be.true;
-          expect(window.sessionStorage.setItem.calledWith(sinon.match({
+          expect(mockSS.setItem.calledWith(sinon.match({
             [interceptorConfigKey]: result
           })));
         });