Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexExchange adapter to v9 #100

Closed
mkendall07 opened this issue Nov 11, 2015 · 5 comments
Closed

Update indexExchange adapter to v9 #100

mkendall07 opened this issue Nov 11, 2015 · 5 comments

Comments

@mkendall07
Copy link
Member

  1. The indexExchange.js adaptor is requesting an indexURL but that needs to be constructed by cygnus_index_start.
  2. Bids should be based on the global index_slots array (as detailed http://wiki.headertag.com/2015/10/05/i-use-an-existing-tag-manager-for-header-bidding/)
  3. Based on the second element you can derive the size from cygnus_index_args another global
    {"device":"D","siteID":158710,"slots":[{"id":"1","width":728,"height":90,"siteID":158710},{"id":"2","width":728,"height":90,"siteID":158710},{"id":"3","width":300,"height":250,"siteID":158710},{"id":"4","width":300,"height":600,"siteID":158710},{"id":"5","width":300,"height":250,"siteID":158710},{"id":"6","width":300,"height":600,"siteID":158710},{"id":"T1_1","width":728,"height":90,"siteID":164113},{"id":"T1_2","width":728,"height":90,"siteID":164113},{"id":"T1_3","width":300,"height":250,"siteID":164113},{"id":"T1_4","width":300,"height":600,"siteID":164113},{"id":"T1_5","width":300,"height":250,"siteID":164113},{"id":"T1_6","width":300,"height":600,"siteID":164113}],"parseFn":"cygnus_index_parse_res"}"
@headertag
Copy link

We will handle these changes and send a push request per Matt's comments. Thanks! =)

@headertag
Copy link

This is now complete per: #119

@headertag
Copy link

@mkendall07 is there a plan in place to merge this change? Let us know how we can help further!

@mkendall07
Copy link
Member Author

Hi @headertag

We plan on integrating this with our next release. Will be merged soon. Thanks!

@mkendall07
Copy link
Member Author

closed per 81d83b5

vzhukovsky added a commit to aol/Prebid.js that referenced this issue Jun 20, 2017
….21.1 to aolgithub-master

* commit '1dbe7dc0defcde19e85856e76da2023f90f26d20':
  Replace null on empty function to prevent console error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants