Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid version 8 broke the floors module #10255

Closed
alinador opened this issue Jul 20, 2023 · 1 comment · Fixed by #10257
Closed

Prebid version 8 broke the floors module #10255

alinador opened this issue Jul 20, 2023 · 1 comment · Fixed by #10257
Assignees

Comments

@alinador
Copy link

Type of issue

From prebid version 8, the floors price module no longer works.

Description

In prebid ver 8, the code is trying to find the floor price by AuctionId, but since AuctionId is undefined, it cannot do so. Additionally, the request structure has changed and proxy objects have been added that prevent getting the auctionId.

image

o.auctionId is undefined in the code
image

but when we use debugger to open the proxy object, the auctionId appears to be valid
image

Steps to reproduce

Using floor price module with prebid ver >=8

Expected results

Floor prices should be sent to bidders

Actual results

There is no floor price sent to bidders

Platform details

Prebid ver >=8

@dgirardi
Copy link
Collaborator

dgirardi commented Jul 20, 2023

Thank you for the report! The proxies were introduced as part of the effort to require opt-in for transaction identifiers. The intent is to proxy only within the scope of bid adapters, but I missed that .getFloor calls outside of it.

Fix is in #10257; if it's an option, you could also work around the issue by opting in (pbjs.setConfig({enableTIDs: true})).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants