priceFloors: fix bug where floors are not set when TIDs are disabled #10257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgirardi
force-pushed
the
fix-floors-tids
branch
from
7650310 to
f3d08f4
Compare
patmmccann
added
the
needs 2nd review
ChrisHuie
approved these changes
Jul 20, 2023
robertrmartinez
approved these changes
Jul 20, 2023
pm-azhar-mulla
pushed a commit
to PubMatic-OpenWrap/Prebid.js
that referenced
this pull request
Aug 17, 2023
10 tasks
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix a bug introduced with 8.0.0: when TIDs are disabled (the default), they are also hidden from the
.getFloor()method of bid requests.Other information
Fixes #10255