-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RubiconBidAdapter: Error while converting bidRequest to ORTB imp; request skipped #10400
Comments
@EskelCz Thanks for flagging, will get a fix ASAP. A workaround is to remove the Here is example code which will delete the rubicon param ( Or you can just edit the adunits directly of course ) pbjs.onEvent('beforeRequestBids', adUnits => {
adUnits.forEach(adUnit => {
if (adUnit.mediaTypes.hasOwnProperty('native')) {
adUnit.bids.forEach(bid => {
if (bid.bidder === 'rubicon') delete bid.params.position;
});
}
});
}); Executing this on your test page and then running an auction has the Rubicon Native Ad Request sent as expected:
Thanks for finding and sorry for the inconvenience! Also FYI, the Rubicon Prebid Server Adapter requires From Rubicon PBS Error Response: I have reached out to our team for more clarity on if this requirement will remain in the future or not. |
PR: #10401 |
@robertrmartinez That was fast, I'm shocked. :) Thanks a lot for the quick fix. As for the |
We updated the Rubicon Adapter to support native somewhat recently. It sends an ORTB2 Native request to our exchange. It looks like you still declare your prebid native adUnits using the "Legacy" prebid format: This is transformed into ORTB and then sent. Well, the Rubicon (Magnite) SSP requires the ORTB native request field called See section This is Hope this helps clear it up @EskelCz If you have any questions about this requirement or any other native questions, please first reach out to your Magnite account representative and they should be able to assist. |
@robertrmartinez I see, that clears it up. I'll use the ORTB configuration and add an empty eventtrackers array, that's no problem. Thanks a lot |
@robertrmartinez I'm testing the fix in 8.12 and I'm seeing another error in the network request. First it shows kind of a misleading warning in console: Then in network request is the actual error:
Here's the complete request: This is my adUnit definition:
It's probably some other misconfiguration on my part, but it's hard to debug since the error is from the back-end. Can you please see what's wrong? |
Hi @EskelCz I am off starting today but am going to pass this along to my team so someone can help you while I am out! Sorry for the issues! We are still ironing out some kinks in our Native setups. |
Here are the validations done by the server-side rubicon adapter: if imp.native.ver is 1.2, unpack the imp.native.request field and make the following validations:
These are the rules of the exchange. |
@bretg Thanks, I missed that in the docs https://docs.prebid.org/dev-docs/bidders/rubicon.html#native I searched Magnite docs and found it only on this page: https://resources.rubiconproject.com/resource/xapi-specifications-3-2/#autoid-1-44-native-request-object EDIT: Found it at the bottom, it's just the anchors that are broken. |
Thanks for the docs bug report @EskelCz. Will report it. I was going to suggest the IAB spec, but sounds like you found that. |
Type of issue
Bug, probably
Description
Bid request for Native format fails with an error, trying to set .pos at a
video
object, which for native isn't there.(Cannot set properties of undefined (setting 'pos'))
This line: https://github.com/prebid/Prebid.js/blob/7.39.0/modules/rubiconBidAdapter.js#L197
Steps to reproduce
Test page
https://playground.cpex.cz/native
(position native-3)
Expected results
No error
Actual results
Platform details
Prebid 7.39 (but the culprit line is in the latest version as well)
The text was updated successfully, but these errors were encountered: