Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebidcache module ignores invalid response #11778

Closed
dmitriyshashkin opened this issue Jun 12, 2024 · 0 comments · Fixed by #11781
Closed

prebidcache module ignores invalid response #11778

dmitriyshashkin opened this issue Jun 12, 2024 · 0 comments · Fixed by #11781

Comments

@dmitriyshashkin
Copy link
Contributor

dmitriyshashkin commented Jun 12, 2024

Type of issue

Bug

Description

https://github.com/prebid/Prebid.js/blob/master/src/videoCache.js#L125
If Cache server responds with some non-JSON response (like Xandr's cache solution does) the response is silently ignored

Steps to reproduce

  1. Setup HB video stack. Use this for the cache server "url":"https://ib.adnxs.com/prebid/cache"
  2. Enable debug output
  3. Add some test bidder that always bid
  4. Request bids

Test page

https://js-debug-2.b-cdn.net/prebid_video_cache/mediaMetadata.html

Expected results

Some error message in console

Actual results

Bid is discarded, no error message is issued

Platform details

Any

Other information

Why I consider it a bug:

  1. If server responds with 502 or if it responds with JSON without UUIDs I get error message. It is illogical to hide error in one particular case, that is when response is not a valid JSON
  2. It makes debugging much harder. Problem with cache server can lead to valid bids being discarded. But the problem does not manifest itself in the debug log.
  3. Invalid JSON response is not an expected response. It indicates that there is a problem with the server. Therefore it should not get ignored.
dgirardi added a commit to dgirardi/Prebid.js that referenced this issue Jun 12, 2024
Fawke pushed a commit that referenced this issue Jun 19, 2024
* move some video cache logic to videoCache.js

* move more video cache logic to videoCache.js

* Fix silent failure on video cache (#11778)
DecayConstant pushed a commit to mediavine/Prebid.js that referenced this issue Jul 18, 2024
* move some video cache logic to videoCache.js

* move more video cache logic to videoCache.js

* Fix silent failure on video cache (prebid#11778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant