Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all bidResponse parameters required #1649

Closed
bretg opened this issue Oct 2, 2017 · 2 comments
Closed

Make all bidResponse parameters required #1649

bretg opened this issue Oct 2, 2017 · 2 comments
Assignees

Comments

@bretg
Copy link
Collaborator

bretg commented Oct 2, 2017

Type of issue

Make Prebid 1.0 treat more bidResponse fields as required

Description

We agreed while specing the interface for Prebid 1.0 that may more parameters are required for bidResponses. All parameters noted as 'required' in the bid object table should cause the bid to be rejected if not present. This will enable it to be caught by unit tests.

http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response

Steps to reproduce

Currently there are several parameters not required

const bidResponse = {
        requestId: bidRequest.bidId,
        bidderCode: spec.code,
        cpm: CPM,
        width: WIDTH,
        height: HEIGHT,
        creativeId: CREATIVE_ID,
        dealId: DEAL_ID,
        referrer: REFERER,
        ad: CREATIVE_BODY
    };

Expected results

The bid response fail somehow because there are 3 missing params:

        currency: CURRENCY,
        netRevenue: true,
        ttl: TIME_TO_LIVE,

Actual results

Doesn't fail.

It's not clear how the adapter would learn about the missing attributes. Need to discuss.

@bretg bretg assigned bretg and jaiminpanchal27 and unassigned bretg Oct 18, 2017
@bretg
Copy link
Collaborator Author

bretg commented Oct 18, 2017

Discussed with the team -- the platform will log missing attributes to the console.

@jaiminpanchal27
Copy link
Collaborator

Closing this as its done in this PR #1738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants