Validating bid response params #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
requested changes
Oct 20, 2017
src/adapters/bidderFactory.js
Outdated
| @@ -107,6 +107,8 @@ import { logWarn, logError, parseQueryStringParameters, delayExecution } from 's | |||
| * @property {string} url The URL which makes the sync happen. | |||
| */ | |||
|
|
|||
| const BID_RESPONSE_KEYS = ['currency', 'netRevenue', 'ttl']; | |||
There was a problem hiding this comment.
We have more required params. You should check http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response ;)
mkendall07
approved these changes
Oct 23, 2017
matthewlane
reviewed
Oct 23, 2017
modules/appnexusAstBidAdapter.js
Outdated
| @@ -183,14 +183,18 @@ function newBid(serverBid, rtbBid) { | |||
| cpm: rtbBid.cpm, | |||
| creative_id: rtbBid.creative_id, | |||
There was a problem hiding this comment.
appnexusAst will need bidderCode andcreativeId added to pass validation now
dbemiller
reviewed
Oct 24, 2017
| const prebidBid = Object.assign(bidfactory.createBid(STATUS.GOOD, bidRequest), bid); | ||
| addBidWithCode(bidRequest.placementCode, prebidBid); | ||
| // In Prebid 1.0 all the validation logic from bidmanager will move here, as of now we are only validating new params so that adapters dont miss adding them. | ||
| if (hasValidKeys(bid)) { |
There was a problem hiding this comment.
Careful here... we've been telling adapters not to add bidderCode, because it breaks aliasing. The bidderFactory should be doing that for them.
But... that happens a few lines after this: Object.assign(bidfactory.createBid(STATUS.GOOD, bidRequest), bid);.
So I don't think should be make sure that bidderCode exists here. If anything, we should make sure that it doesn't exist yet.
mkendall07
reviewed
Oct 24, 2017
src/adapters/bidderFactory.js
Outdated
| @@ -107,6 +107,8 @@ import { logWarn, logError, parseQueryStringParameters, delayExecution } from 's | |||
| * @property {string} url The URL which makes the sync happen. | |||
| */ | |||
|
|
|||
| const BID_RESPONSE_KEYS = ['requestId', 'bidderCode', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency']; | |||
There was a problem hiding this comment.
Per recent discussion, it looks like bidderCode should not be a required param.
…dresponse # Conflicts: # test/spec/modules/appnexusAstBidAdapter_spec.js
|
I think ideally we'd want to validate on media type (probably create different bid objects for the different types) but that doesn't have to be done in this PR. |
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 31, 2017
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
mattpr
pushed a commit
to mattpr/Prebid.js
that referenced
this pull request
Oct 31, 2017
* validating bid response params * added all required params * replaced id with correct param requestid * keeping only common keys to validate
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* validating bid response params * added all required params * replaced id with correct param requestid * keeping only common keys to validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Validating bid response params
currency, 'netRevenueandttl` for 1.0 adapters.