Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Adkernel adapter for 1.0 api #1722

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Update Adkernel adapter for 1.0 api #1722

merged 1 commit into from
Oct 26, 2017

Conversation

ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Oct 18, 2017 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Migrating Adkernel adapter to api 1.0

@ckbo3hrk ckbo3hrk force-pushed the adkernel_1.0 branch 2 times, most recently from 7f78797 to 15dd3cc Compare October 20, 2017 09:58
@jaiminpanchal27 jaiminpanchal27 self-assigned this Oct 20, 2017
dbemiller
dbemiller suggested changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@dbemiller dbemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the markdown file with test params & maintainer email: http://prebid.org/dev-docs/bidder-adapter-1.html#planning-your-adapter

modules/adkernelBidAdapter.js Outdated
return requests;
},
interpretResponse: function(serverResponse, request) {
/* istanbul ignore if */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our linter won't fail on this... so you can remove it (along with the other istanbul suppressions you've got around here)

modules/adkernelBidAdapter.js Outdated
return rtbBids.map(rtbBid => {
let imp = rtbImps.find(imp => imp.id === rtbBid.impid);
let prBid = {
bidderCode: spec.code,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our docs are bad... but you shouldn't send back the bidderCode here. The bidderFactory code does it automatically, and It breaks adapter aliasing if you do it yourself.

@dbemiller dbemiller self-assigned this Oct 24, 2017
@dbemiller
Copy link
Contributor

dbemiller commented Oct 24, 2017 •
edited
Loading

One more change, now that #1742 got merged.

The first argument to interpretResponse now looks like this:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

You'll have to update the spec so that it looks through that object as well now.

@ckbo3hrk
Copy link
Contributor Author

@dbemiller everything is done

@dbemiller dbemiller mentioned this pull request Oct 25, 2017
Merged
dbemiller
dbemiller suggested changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@dbemiller dbemiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

akh... one last bug I just noticed.

modules/adkernelBidAdapter.js Outdated
dispatcher.addImp(bid);
let result = [];
serverResponses.forEach(response => {
if (response.ext && response.ext.adk_usersync) {
Copy link
Contributor

@dbemiller dbemiller Oct 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1748, the server response format changed here as well. It now looks like { body: responseBody, ... } This was intentional... but I forgot to mention it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbemiller done

@jaiminpanchal27 jaiminpanchal27 removed their assignment Oct 26, 2017
@dbemiller dbemiller merged commit d4a1423 into prebid:master Oct 26, 2017
Millerrok pushed a commit to Vertamedia/Prebid.js that referenced this pull request Oct 31, 2017
Merge branch 'master' of https://github.com/prebid/Prebid.js
e45235f 
* 'master' of https://github.com/prebid/Prebid.js: (22 commits)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  Update Conversant adapter to Prebid 1.0 (prebid#1711)
  Fix test-coverage bug (prebid#1765)
  Migrating TrustX adapter to 1.0 (prebid#1709)
  Update Improve Digital adapter for Prebid 1.0 (prebid#1728)
  Fixed the argument type on getUserSyncs. (prebid#1767)
  nanointeractive bid adapter (prebid#1627)
  Validating bid response params (prebid#1738)
  ...
mattpr pushed a commit to mattpr/Prebid.js that referenced this pull request Oct 31, 2017
@ckbo3hrk @mattpr
updated for prebid 1.0 api (prebid#1722)
39e51fd
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Nov 13, 2017
Merge tag '0.32.0' of https://github.com/prebid/Prebid.js into prebuilt
d52f0c7 
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits)
  Prebid 0.32.0 Release
  Commenting out tests that are failing in IE10 (prebid#1710)
  Update dfp.buildVideoUrl to accept adserver url (prebid#1663)
  Update rubicon adapter with new properties and 1.0 changes (prebid#1776)
  Added adUnitCode for compatibility (prebid#1781)
  Remove 'supported' from analytics adapter info (prebid#1780)
  Add TTL parameter to bid (prebid#1784)
  Update GetIntent adapter to 1.0 version (prebid#1721)
  Add `usePaymentRule` param to AN bidders (prebid#1778)
  New hooks API (replaces monkey-patching for currency) (prebid#1683)
  Change prebidServer to call client user syncs if they exist (prebid#1734)
  Fix Centro adapter to allow requests of the same units (prebid#1746)
  add vastUrl + media type for video bids Prebid Server (prebid#1739)
  Update adxcg adapter for prebid 1.0 (prebid#1741)
  Update yieldmoBid adapter request url (prebid#1771)
  Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753)
  Fidelity Media Adapter update. Prebid v1.0 (prebid#1719)
  Kargo Adapter for Prebid 1.0 (prebid#1729)
  updated for prebid 1.0 api (prebid#1722)
  Add AdOcean adapter (prebid#1735)
  ...
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
@ckbo3hrk @dluxemburg
updated for prebid 1.0 api (prebid#1722)
13d4354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiminpanchal27 jaiminpanchal27 jaiminpanchal27 approved these changes

@dbemiller dbemiller dbemiller approved these changes

Assignees

@dbemiller dbemiller

Labels
needs update Prebid 1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ckbo3hrk @dbemiller @jaiminpanchal27 @mjacobsonny