-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response headers are required but missing in interpretResponse #1742
Comments
francoroy
changed the title
Missing data fropm ajax request.
response headers are required but missing in interpretResponse
Oct 22, 2017
This is a good point. I chatted with @mkendall07 about this, and we agreed that it's so early that breaking the API to keep it clean is a good idea. I'll work on this early today, and we'll try to rush a review so that we can merge it in later. There aren't too many 1.0 adapters in yet... so it won't be hard to update them. |
ghost
added
the
in progress
label
Oct 23, 2017
ghost
removed
the
in progress
label
Oct 24, 2017
This was referenced Oct 24, 2017
This was referenced Oct 24, 2017
9 tasks
tzafrirb
added a commit
to tzafrirb/Prebid.js
that referenced
this issue
Oct 31, 2017
…, the bidderFactory is calling your adapter with interpretResponse({ body: body, ... })
jaiminpanchal27
pushed a commit
that referenced
this issue
Nov 1, 2017
* Prebid 1.0 compliant bidder adapter * PlacementId and hbId support display test banner * Remove aliases * remove check for aliases, breaks build * Add bid response test with mandatory params * change #1742 (#1742): rather than interpretResponse(body), the bidderFactory is calling your adapter with interpretResponse({ body: body, ... }) * replace describe with it
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this issue
Jul 17, 2018
* Prebid 1.0 compliant bidder adapter * PlacementId and hbId support display test banner * Remove aliases * remove check for aliases, breaks build * Add bid response test with mandatory params * change prebid#1742 (prebid#1742): rather than interpretResponse(body), the bidderFactory is calling your adapter with interpretResponse({ body: body, ... }) * replace describe with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, at:
Prebid.js/src/adapters/bidderFactory.js
Line 274 in be21952
The response body is sent back to the adapter, while in some cases additional response data is required, for example - in mobfox adapter, the bid value is returned as a response header.
Any rejections to adding the response headers as a third parameter (so that it'd be optional and non-breaking for those who've already implemented their new adapter) ?
Thanks
The text was updated successfully, but these errors were encountered: