-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Audience Network adapter for Prebid 1.0 #1750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @lovell, can you make these changes against master
? It'll reduce merge conflicts and make the branches easier for us to maintain during the 1.0 transition.
Thanks!
modules/audienceNetworkBidAdapter.js
Outdated
const bidResponse = { | ||
// Prebid attributes | ||
requestId, | ||
bidderCode: code, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some subtle reasons, you shouldn't set bidderCode
in here. It breaks adapter aliasing.
Our docs have been updated to reflect this... but sorry for the confusion all the same.
0b7645e
to
db35f30
Compare
agh... sorry about this, but one more change, because #1742 got merged before we could get this in. The first argument to
Could you also pull master and update that? |
db35f30
to
2400b57
Compare
Updated and rebased against master but other, unrelated unit tests are failing at the moment. |
As requested by @mjacobsonny and paid for by Facebook.
In addition to 100% unit test branch coverage, I've manually tested this using
pbjs_debug=true
and everything appears to be working end-to-end.The two biggest gotchas I ran into that required me to dig into the new Prebid source code to determine expected behaviour were:
ServerRequest
expected frombuildRequests()
documented at http://prebid.org/dev-docs/bidder-adapter-1.html#building-the-requestbidId
passed tobuildRequests()
as the differently-namedrequestId
property of thebidObject
returned byinterpretResponse()
.