Fidelity Media Adapter update. Prebid v1.0 #1719

onaydenov · 2017-10-18T11:09:25Z

Type of change

Description of change

Fidelity Media Adapter update. Prebid v1.0 and features update.

test parameters for validating bids

{
  bidder: 'fidelity',
  params: {
    zoneid: '27248',
    floor: 0.01,
    server: 'x.fidelity-media.com'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer on@fidelity-media.com
official adapter submission

Other information

Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now.

onaydenov · 2017-10-18T14:33:17Z

We've been trying reproduce error locally with no success. Local tests pass normally. Please look into and let me know how to proceed with the PR further.

jaiminpanchal27 · 2017-10-18T14:49:23Z

@onaydenov Checks seem to pass after restarting the build. I will check your PR probably today.

jaiminpanchal27

@onaydenov Thanks for submitting 1.0 adapter.
Just 1 minor change in code is required.

Also add .md file http://prebid.org/dev-docs/bidder-adapter-1.html#planning-your-adapter

jaiminpanchal27 · 2017-10-20T14:47:19Z

modules/fidelityBidAdapter.js

+ interpretResponse: function(serverResponse) {
+ const bidResponses = [];
+ if (serverResponse && serverResponse.seatbid) {
+ serverResponse.seatbid.forEach(seatBid => seatBid.bid.forEach(bid => {


Need to add required field ttl : Time-to-Live - how long (in seconds) Prebid can use this bid

Ok, thanks for review. I'll add .md and update adapter by the end of today hopefully.

@jaiminpanchal27 All done. Changes were made, checks passed.

dbemiller · 2017-10-24T13:29:14Z

modules/fidelityBidAdapter.js

+ if (serverResponse && serverResponse.seatbid) {
+ serverResponse.seatbid.forEach(seatBid => seatBid.bid.forEach(bid => {
+ const bidResponse = {
+ bidderCode: spec.code,


Hey,

I made some last minute changes to adapter aliasing, and our docs are out of date... but could you remove this bidderCode? It's not required, and will actually break things.

Thanks

Also add creativeId as it is a required param.

Ok, we'll do both. I'll upload new code ASAP.

@dbemiller @jaiminpanchal27 These updates are done, take a look at result.

jaiminpanchal27 · 2017-10-25T14:17:30Z

@onaydenov Its LGTM now, except this one below.
Apologies for this, #1742 got merged recently.

The first argument to interpretResponse now looks like this:

{
  body: responseBody,
  headers: {
    get: function(header) { /* returns a header from the HTTP response */ }
  }
}

You'll have to pull master and update the spec so that it looks digs into that object as well now.

onaydenov · 2017-10-25T21:25:45Z

@jaiminpanchal27 Done. Could you check and approve.

* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...

* Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media fmxSSP Adapter update. Prebid v1.0 * Fidelity Media. Prebid v 1.0 Add tmax * Fidelity Media. Prebid v 1.0. ttl * Fidelity Media. Prebid v 1.0. spec * Less bidderCode, add creativeId * Adapter v.1, less bidderCode, add creativeId * Prebid v1. InterpretResponse. Spec. * InterpretResponse * InterpretResponse

* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...

* Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media Adapter update. Prebid v1.0. Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now. * Fidelity Media fmxSSP Adapter update. Prebid v1.0 * Fidelity Media. Prebid v 1.0 Add tmax * Fidelity Media. Prebid v 1.0. ttl * Fidelity Media. Prebid v 1.0. spec * Less bidderCode, add creativeId * Adapter v.1, less bidderCode, add creativeId * Prebid v1. InterpretResponse. Spec. * InterpretResponse * InterpretResponse

onaydenov added 2 commits October 18, 2017 12:59

Fidelity Media Adapter update. Prebid v1.0.

43d2ca9

Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now.

Fidelity Media Adapter update. Prebid v1.0.

563d8e1

Fidelity Media Adapter update. Prebid v1.0 plus featutes update. Add Prebid v1.0 support Add parameter "floor" Removed: "Loc" "Click" "SubId" Subid=HB trasferred to SSP by default now.

onaydenov changed the title ~~Prebid 1.0 fidelityadapterupdate~~ Fidelity Media Adapter update. Prebid v1.0 Oct 18, 2017

mjacobsonny added the Prebid 1.0 label Oct 18, 2017

jaiminpanchal27 self-assigned this Oct 18, 2017

jaiminpanchal27 added the needs review label Oct 18, 2017

jaiminpanchal27 requested changes Oct 20, 2017

View reviewed changes

jaiminpanchal27 added needs update and removed needs review labels Oct 20, 2017

onaydenov added 4 commits October 20, 2017 18:23

Fidelity Media fmxSSP Adapter update. Prebid v1.0

58012ac

Fidelity Media. Prebid v 1.0 Add tmax

32904c4

Fidelity Media. Prebid v 1.0. ttl

aeb7b13

Fidelity Media. Prebid v 1.0. spec

b009b16

dbemiller reviewed Oct 24, 2017

View reviewed changes

onaydenov added 2 commits October 25, 2017 01:21

Less bidderCode, add creativeId

9204c35

Adapter v.1, less bidderCode, add creativeId

c1ef347

jaiminpanchal27 approved these changes Oct 25, 2017

View reviewed changes

onaydenov added 3 commits October 26, 2017 00:06

Prebid v1. InterpretResponse. Spec.

3a901ff

InterpretResponse

7ad9f4d

InterpretResponse

6497042

jaiminpanchal27 added LGTM and removed needs update labels Oct 26, 2017

jaiminpanchal27 assigned matthewlane and unassigned jaiminpanchal27 Oct 26, 2017

dbemiller merged commit c5d1ecf into prebid:master Oct 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fidelity Media Adapter update. Prebid v1.0 #1719

Fidelity Media Adapter update. Prebid v1.0 #1719

onaydenov commented Oct 18, 2017

onaydenov commented Oct 18, 2017

jaiminpanchal27 commented Oct 18, 2017

jaiminpanchal27 left a comment

jaiminpanchal27 Oct 20, 2017

onaydenov Oct 20, 2017

onaydenov Oct 20, 2017

dbemiller Oct 24, 2017

jaiminpanchal27 Oct 24, 2017

onaydenov Oct 24, 2017

onaydenov Oct 24, 2017

jaiminpanchal27 commented Oct 25, 2017

onaydenov commented Oct 25, 2017

Fidelity Media Adapter update. Prebid v1.0 #1719

Fidelity Media Adapter update. Prebid v1.0 #1719

Conversation

onaydenov commented Oct 18, 2017

Type of change

Description of change

Other information

onaydenov commented Oct 18, 2017

jaiminpanchal27 commented Oct 18, 2017

jaiminpanchal27 left a comment

Choose a reason for hiding this comment

jaiminpanchal27 Oct 20, 2017

Choose a reason for hiding this comment

onaydenov Oct 20, 2017

Choose a reason for hiding this comment

onaydenov Oct 20, 2017

Choose a reason for hiding this comment

dbemiller Oct 24, 2017

Choose a reason for hiding this comment

jaiminpanchal27 Oct 24, 2017

Choose a reason for hiding this comment

onaydenov Oct 24, 2017

Choose a reason for hiding this comment

onaydenov Oct 24, 2017

Choose a reason for hiding this comment

jaiminpanchal27 commented Oct 25, 2017

onaydenov commented Oct 25, 2017