Upgrade Quantcast adapter for Prebid 1.0 #1753

ghost · 2017-10-24T04:39:22Z

Type of change

New bidder adapter

Description of change

test parameters for validating bids

{
    bidder: 'quantcast',
    params: {
        publisherId: 'test-publisher', // REQUIRED - Publisher ID provided by Quantcast
        battr: [1, 2] // OPTIONAL - Array of blocked creative attributes as per OpenRTB Spec List 5.3
    }
}

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer
official adapter submission

Other information

N/A

This reverts commit 459ca31.

jaiminpanchal27 · 2017-10-24T20:55:31Z

modules/quantcastBidAdapter.js

 method: 'POST',
+ url,
 withCredentials: true


You don't need to pass withCredentials:true. Its already set in bidderFactory https://github.com/prebid/Prebid.js/blob/master/src/adapters/bidderFactory.js#L263

Removed 1322e00

jaiminpanchal27 · 2017-10-24T20:57:05Z

modules/quantcastBidAdapter.js

+ const { ad, cpm, width, height } = bid;
+
+ return {
+ ad,


Need to add required params. Please check http://prebid.org/dev-docs/bidder-adapter-1.html for list
Also bidderCode was previously required param but now you can remove that as it is handled by bidderFactory

1710251031
Working with the team to solve this issue; bidderCode removed 1322e00;

1710251358
Add the required params d6a00e6

jaiminpanchal27 · 2017-10-24T20:57:35Z

modules/quantcastBidAdapter.js


-adaptermanager.registerBidAdapter(new QuantcastAdapter(), 'quantcast');
+ getUserSyncs(syncOptions) {


You can remove this method if not needed at this moment.

Removed 1322e00

jaiminpanchal27 · 2017-10-24T21:06:46Z

modules/quantcastBidAdapter.js

+ * @return {Bid[]} An array of bids which were nested inside the server.
+ *
+ */
+ interpretResponse(serverResponse) {


#1742 got merged recently.

The first argument to interpretResponse now looks like this:

{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}
You'll have to pull master and update the spec so that it looks digs into that object as well now.

Updated with bee2344 and 417852e

jaiminpanchal27 · 2017-10-24T21:07:22Z

modules/quantcastBidAdapter.js

+export const spec = {
+ code: BIDDER_CODE,
+
+ // `BaseAdapter` model saves adapter from having to make the AJAX call


This comment chunk can be removed.

Removed 1322e00

ghost · 2017-10-25T03:47:51Z

I talked to our team and we are going add the missing required parameters later today.

ghost · 2017-10-25T04:37:49Z

I have updated all the required changes @jaiminpanchal27 mentioned in the issue. The corresponding back-end change will deploy soon.

* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...

* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...

Li Xinyang and others added 18 commits October 15, 2017 18:18

Add v1.0 adapter skeleton

b87dc31

Fix a typo in variable name declaration

275b772

Change spec dependencies

017c89c

Add new describes for test

e94e790

Move URL detechtion inside buildRequests method

08c4300

Add necessary cases

d276ad1

Clean test cases

642115d

Export Quantcast adapter constants

444a2bf

Implemenent test cases

d99851e

Fix wrong ports number

5a7809e

Correct test cases

553b34d

Make string with single quote

abf387a

Remove unused statements

459ca31

Revert "Remove unused statements"

83a4de0

This reverts commit 459ca31.

Remove unused statements

6520c69

Change string to single quote

7ad07a0

Fix sizes type

c79279f

Fix the sizes propty name typo in the spec

b95315f

mjacobsonny added the Prebid 1.0 label Oct 24, 2017

jaiminpanchal27 requested changes Oct 24, 2017

View reviewed changes

jaiminpanchal27 added the needs update label Oct 24, 2017

Li Xinyang added 5 commits October 25, 2017 09:44

Remove unused method, key value and comments

1322e00

Update the spec

4b1aef8

Change code using single quote

2b56022

Update the first argument for interpretResponse method and its spec

bee2344

Handle undefined Server Response

417852e

Add required params from the server response

d6a00e6

jaiminpanchal27 approved these changes Oct 25, 2017

View reviewed changes

jaiminpanchal27 added LGTM and removed needs update labels Oct 25, 2017

jaiminpanchal27 assigned matthewlane Oct 26, 2017

matthewlane approved these changes Oct 26, 2017

View reviewed changes

matthewlane merged commit 51ffb4e into prebid:master Oct 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Quantcast adapter for Prebid 1.0 #1753

Upgrade Quantcast adapter for Prebid 1.0 #1753

ghost commented Oct 24, 2017 •

edited by ghost

Loading

jaiminpanchal27 Oct 24, 2017

ghost Oct 25, 2017

jaiminpanchal27 Oct 24, 2017

ghost Oct 25, 2017 •

edited by ghost

Loading

jaiminpanchal27 Oct 24, 2017

ghost Oct 25, 2017

jaiminpanchal27 Oct 24, 2017

ghost Oct 25, 2017

jaiminpanchal27 Oct 24, 2017

ghost Oct 25, 2017

ghost commented Oct 25, 2017

ghost commented Oct 25, 2017


		adaptermanager.registerBidAdapter(new QuantcastAdapter(), 'quantcast');
		getUserSyncs(syncOptions) {

Upgrade Quantcast adapter for Prebid 1.0 #1753

Upgrade Quantcast adapter for Prebid 1.0 #1753

Conversation

ghost commented Oct 24, 2017 • edited by ghost Loading

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Oct 25, 2017 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Oct 25, 2017

ghost commented Oct 25, 2017

ghost commented Oct 24, 2017 •

edited by ghost

Loading

ghost Oct 25, 2017 •

edited by ghost

Loading