AdOcean Adpater for Prebid 1.0 #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
requested changes
Oct 23, 2017
modules/adoceanBidAdapter.js
Outdated
| return bids; | ||
| }, | ||
|
|
||
| getUserSyncs: function(syncOptions) { |
There was a problem hiding this comment.
If your adapter doesn't need user syncing, this function can be removed
| @@ -0,0 +1,147 @@ | |||
| import { expect, use } from 'chai'; | |||
There was a problem hiding this comment.
Looks like use is imported but not used in the test, can be removed
| currency: placementResponse.currency, | ||
| height: parseInt(placementResponse.height, 10), | ||
| requestId: bidRequest.bidIdMap[placementResponse.id], | ||
| width: parseInt(placementResponse.width, 10), |
There was a problem hiding this comment.
creativeId, netRevenue, and ttl should also be in this object as well. See the table in http://prebid.org/dev-docs/bidder-adapter-1.html#interpreting-the-response for information about these fields
matthewlane
reviewed
Oct 24, 2017
modules/adoceanBidAdapter.js
Outdated
|
|
||
| const bid = { | ||
| ad: adCode, | ||
| bidderCode: BIDDER_CODE, |
There was a problem hiding this comment.
bidderCode can be dropped as well, it'll be set automatically by bidderFactory. Docs are being updated now, sorry for the confusion prebid/prebid.github.io#411
matthewlane
reviewed
Oct 24, 2017
| return requests; | ||
| }, | ||
|
|
||
| interpretResponse: function(serverResponse, bidRequest) { |
There was a problem hiding this comment.
One more change with #1748 now merged to master:
The first argument to interpretResponse has been changed, and now looks like this:
{
body: responseBody,
headers: {
get: function(header) { /* returns a header from the HTTP response */ }
}
}So to retain the same functionality as before, doing something like
serverResponse = serverResponse.body;just below this line (or however you'd prefer) , and in tests as needed, should help
Could you rebase off of master and update that?
|
Fixed and rebased to master. |
matthewlane
approved these changes
Oct 26, 2017
Millerrok
pushed a commit
to Vertamedia/Prebid.js
that referenced
this pull request
Oct 31, 2017
* 'master' of https://github.com/prebid/Prebid.js: (22 commits) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) Update Conversant adapter to Prebid 1.0 (prebid#1711) Fix test-coverage bug (prebid#1765) Migrating TrustX adapter to 1.0 (prebid#1709) Update Improve Digital adapter for Prebid 1.0 (prebid#1728) Fixed the argument type on getUserSyncs. (prebid#1767) nanointeractive bid adapter (prebid#1627) Validating bid response params (prebid#1738) ...
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Nov 13, 2017
* tag '0.32.0' of https://github.com/prebid/Prebid.js: (44 commits) Prebid 0.32.0 Release Commenting out tests that are failing in IE10 (prebid#1710) Update dfp.buildVideoUrl to accept adserver url (prebid#1663) Update rubicon adapter with new properties and 1.0 changes (prebid#1776) Added adUnitCode for compatibility (prebid#1781) Remove 'supported' from analytics adapter info (prebid#1780) Add TTL parameter to bid (prebid#1784) Update GetIntent adapter to 1.0 version (prebid#1721) Add `usePaymentRule` param to AN bidders (prebid#1778) New hooks API (replaces monkey-patching for currency) (prebid#1683) Change prebidServer to call client user syncs if they exist (prebid#1734) Fix Centro adapter to allow requests of the same units (prebid#1746) add vastUrl + media type for video bids Prebid Server (prebid#1739) Update adxcg adapter for prebid 1.0 (prebid#1741) Update yieldmoBid adapter request url (prebid#1771) Upgrade Quantcast adapter for Prebid 1.0 (prebid#1753) Fidelity Media Adapter update. Prebid v1.0 (prebid#1719) Kargo Adapter for Prebid 1.0 (prebid#1729) updated for prebid 1.0 api (prebid#1722) Add AdOcean adapter (prebid#1735) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
new bidder adapter .