Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ix/indexExchange adunit config docs error? #2590

Closed
ptim opened this issue May 22, 2018 · 2 comments
Closed

ix/indexExchange adunit config docs error? #2590

ptim opened this issue May 22, 2018 · 2 comments
Labels

Comments

@ptim
Copy link
Contributor

ptim commented May 22, 2018

Type of issue

IX Documentation / adunit configuration

(this is a documentation issue, but it's in the prebid module source, so I figure this is the appropriate place...)

Description

I think the line linked should read: siteId: '4622',... is that right?
https://github.com/prebid/Prebid.js/pull/2496/files#diff-a2f2834ff17b6a970602a20e6ad5db67R150

I need to confirm that the siteId need not be unique between sizes in a single placement (please see the example - looks like a typo)

CC @indexexchange

Example

var adUnits = [{
    code: 'banner-div-a',
    mediaTypes: {
        banner: {
            sizes: [
                [300, 250],
                [300, 600]
            ]
        }
    },
    bids: [{
        bidder: 'ix',
        params: {
            siteId: '4622',
            size: [300, 250]
        }
    }, {
        bidder: 'ix',
        params: {
            siteId: '6242', // should this read '4622'?
            size: [300, 600]
        }
    }]
}];
@jnsprngs
Copy link

Index emailed out a supplemental PDF with a few details on implementation. In it they said, "Please note that you can re-use the existing siteId within the same flex position."

So I would take that as confirmation that they want you to use the same siteId within a adUnit for the n different sizes you want to support in that adUnit.

@stale
Copy link

stale bot commented Jun 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 7, 2018
@stale stale bot closed this as completed Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants