Update ixBidAdapter.md #2598
Merged
Update ixBidAdapter.md #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify use of `siteId` and fix mismatch of `siteId` for 'flex position' units based on documentation emailed out: https://gallery.mailchimp.com/41ac5884406c48bd6f31af7a1/files/09ffb712-5455-4c0c-8453-592c5a3bcb67/Prebid_1.0_Upgrade_Doc_052118_v2.pdf Further clarification is recommended, given the comment in the FAQ: > An IX site ID maps to a single size, whereas an ad unit can have multiple sizes. To ensure that the right site ID is mapped to the correct size in the ad unit we require the size to be explicitly stated. ...which contradicts the statement in the upgrade documentation linked above, which states: > Please note that you can re-use the existing `siteId` within the same flex position.
Pupis
pushed a commit
to adform/Prebid.js
that referenced
this pull request
Jun 7, 2018
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Clarify use of
siteIdand fix mismatch ofsiteIdfor 'flex position' units based on documentation emailed out:https://gallery.mailchimp.com/41ac5884406c48bd6f31af7a1/files/09ffb712-5455-4c0c-8453-592c5a3bcb67/Prebid_1.0_Upgrade_Doc_052118_v2.pdf
Further clarification is recommended, given the comment in the FAQ:
...which contradicts the statement in the upgrade documentation linked above, which states:
Contact email of the adapter’s maintainer: prebid.support@indexexchange.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information
@indexexchange