Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JustPremium - Make format available #2691

Closed
muuki88 opened this issue Jun 7, 2018 · 1 comment
Closed

JustPremium - Make format available #2691

muuki88 opened this issue Jun 7, 2018 · 1 comment

Comments

@muuki88
Copy link
Collaborator

muuki88 commented Jun 7, 2018

Feature Request

Add format information to JustPremium adapter.

Description

The justPremium server response contains the creative format.
See the passCond function

This information is not available on the bidResponse object that is created by the adapter

We require this information in order to target lineItems properly on different formats.
The adserverTargeting in the bidderSettings would look something like this

justpremium: {
  adserverTargeting: [
     // other targeting stuff
    {
      key: 'hb_format_justpremi',
      val : (bidResponse) => bidResponse.format
    }
  ]
}

Expected results

The JustPremium bidResponse object contains the format. E.g. wp, pu, etc.

Actual results

The JustPremium bidResponse object doesn't contain the format.

Platform details

Prebid.js 1.13.0

Other information

@nwlosinski implemented the prebid adapter.

nwlosinski pushed a commit to nwlosinski/Prebid.js that referenced this issue Jun 7, 2018
nwlosinski pushed a commit to nwlosinski/Prebid.js that referenced this issue Jun 7, 2018
mike-chowla pushed a commit that referenced this issue Jun 11, 2018
* add format parameter to bid response
@muuki88
Copy link
Collaborator Author

muuki88 commented Jun 12, 2018

Sweet 👍

@muuki88 muuki88 closed this as completed Jun 12, 2018
dluxemburg pushed a commit to Genius/Prebid.js that referenced this issue Jul 17, 2018
florevallatmrf pushed a commit to Marfeel/Prebid.js that referenced this issue Sep 6, 2018
StefanWallin pushed a commit to mittmedia/Prebid.js that referenced this issue Sep 28, 2018
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this issue Jan 30, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this issue Mar 26, 2019
AlessandroDG pushed a commit to simplaex/Prebid.js that referenced this issue Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant