Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iframes should not be injected into <head> #3413

Closed
mbova opened this issue Jan 2, 2019 · 2 comments
Closed

iframes should not be injected into <head> #3413

mbova opened this issue Jan 2, 2019 · 2 comments
Labels
bug good first issue

Comments

@mbova
Copy link

mbova commented Jan 2, 2019 •
edited
Loading

Type of issue

Bug

Description

Currently iframes get injected into the head. Google has said this can cause a problem with them reading all the meta tags because the iframes implicitly close the head and push the meta tags into the body. source

They recommend to inject just before the closing </html> tag instead of at the top of the <head>

Steps to reproduce

Load page using prebid
watch for iframes to inject into <head>

Test page

Expected results

Actual results

screen shot 2018-11-28 at 2 51 47 pm

Platform details

Other information
@mkendall07
Copy link
Member

thanks for the feedback - this makes sense to me.

@deekshithraop deekshithraop mentioned this issue Jan 3, 2019
Merged
1 task
@snapwich
Copy link
Collaborator

closed via #3415

@patmmccann patmmccann mentioned this issue Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snapwich @mbova @mkendall07