Insert iframe as the last child of Html tag #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deekshithraop
changed the title
mkendall07
requested changes
Jan 7, 2019
|
@jsnellbaker |
jsnellbaker
requested changes
Jan 8, 2019
jsnellbaker
approved these changes
Jan 8, 2019
amuraco
pushed a commit
to amuraco/Prebid.js
that referenced
this pull request
Jan 28, 2019
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes
ghost
pushed a commit
to devunrulymedia/Prebid.js
that referenced
this pull request
Jan 30, 2019
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes
pedrolopezmrf
pushed a commit
to Marfeel/Prebid.js
that referenced
this pull request
Mar 18, 2019
* 3413-Insert Iframes for user sync in body * Append Iframe as the last child * Add unit test for insertElement * utls insert element at the top by default * add unit tests for utls insert element * Insert iframe as html last child * revert package.lock changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Will Insert Iframes as last children of html tag, currently they are inserted in the head.
corresponding issue reported (#3413)
corresponding doc changes (prebid/prebid.github.io#1077)