AppNexus Video Adapter video-size issue or potentially adapterManager.js issue

[potench]

Type of issue

Bug

Description

adapterManager.js does not map the video.playerSize to bid.sizes, so the response from appNexusBidAdapter.js is always {"error":"parse"}. Other adapters also expect bid.sizes to a mapping from video.playerSize that no longer works as expected.

I believe the functionality changed between adapterManager.js in 1.25.0 (working as expected) and was refactored in 1.26.0 (bug)

Original: 1.25.0

1. adUnit.sizes = video.playerSize; link
2. getBids() returns bid object with sizes: link

Refactor with Bug: 1.26.0+

1. getBids() returns bid object with just banner sizes: link

Steps to reproduce

1. Create a video unit with specified playerSize

let video1 = [{
  code: 'test1',
  bids: [],
  sizes: [[640, 480]],
  mediaTypes: {
    video: {
      playerSize: [[640, 480]],
      context: 'instream'
    }
  }
}];

2. Attach a video adapter that depends on bid.sizes (such as appnexus)

{
    bidder: 'appnexus',
    params: {
        placementId: '13960600',
        video: {
            frameworks: [1, 2],
            maxduration: 30,
            mimes: ['video/mp4'],
            minduration: 15,
            playback_method: ['auto_play_sound_off'],
            skippable: true
        }
    }
}

3. Run auction, see auctionManager.js:getBids() does not map video.playerSize to bid.sizes so the outbound request to https://ib.adnxs.com/ut/v3/prebid fails with response {"error":"parse"}

Test page

None

Expected results

Outbound fetch to appnexus should contain {"tags":[{"sizes":[{"width":640,"height":360}] object

curl 'https://ib.adnxs.com/ut/v3/prebid' -H 'Referer: https://quizzes.howstuffworks.com/' -H 'Origin: https://quizzes.howstuffworks.com' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.81 Safari/537.36' -H 'DNT: 1' -H 'Content-Type: text/plain' --data-binary '{"tags":[{"sizes":[{"width":640,"height":360}],"primary_size":{"width":640,"height":360},"ad_types":["video"],"uuid":"432043d3be0a714","id":13960598,"allow_smaller_sizes":false,"use_pmt_rule":false,"prebid":true,"disable_psa":true,"require_asset_url":true,"video":{"frameworks":[1,2],"maxduration":30,"mimes":["video/x-ms-wmv","video/mp4","video/mov","video/webm","application/javascript"],"minduration":15,"playback_method":["auto_play_sound_off"],"skippable":true}}],"sdk":{"source":"pbjs","version":"1.16.0-pltx-3384"}}' --compressed

With network response

{"version":"3.0.0","tags":[{"uuid":"432043d3be0a714","tag_id":13960598,"auction_id":"2358091962087060415","nobid":true,"ad_profile_id":767695}]}

Actual results

Outbound fetch to appnexus contains empty sizes array {"tags":[{"sizes":[]}]} object

Which results in network response

{"error":"parse"}

Platform details

Bug appeared between 1.25.0 and 1.26.0;

Other information