Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: set cookie domain in pubcid / userid on main domain, not subdomain #3873

Closed
adxcgcom opened this issue May 30, 2019 · 8 comments
Closed
Assignees

Comments

@adxcgcom
Copy link
Contributor

adxcgcom commented May 30, 2019

Type of issue

Feature request

Description

It is useful to have one pubCommonId for domain, not for each subsite.

As a possibile solution: in pbjs.setConfig publisher should set storage domain for cookie.

Steps to reproduce

In fresh browser open Prebid auction with pubCommonId / unifiedId module enabled.

After checking LOCAL set cookies in Chrome: Application->cookies we see that both modules set cookie domain to

subdomain.domain.com

it would be better to have this set at
domain.com (without subdomain), the same as other cookies.

Expected results

Set cookie domain to
domain.com

Actual results

Cookie domain is set to
subdomain.domain.com

@stale
Copy link

stale bot commented Jun 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 13, 2019
@mkendall07
Copy link
Member

@idettman
can you take a look at this?

@stale stale bot removed the stale label Jun 17, 2019
@stale
Copy link

stale bot commented Jul 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 1, 2019
@stale stale bot closed this as completed Jul 8, 2019
@mkendall07 mkendall07 reopened this May 27, 2020
@stale stale bot removed the stale label May 27, 2020
@idettman
Copy link
Contributor

idettman commented Jun 2, 2020

The file modules/userId/index.js contains the setCookie call used by all the submodules, so the main domain could be passed as the domain argument for setCookie(key, value, expires, sameSite, domain, done). I'll create a PR for this fix

@stale
Copy link

stale bot commented Jun 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2020
@idettman idettman added assigned and removed stale labels Jun 17, 2020
@idettman
Copy link
Contributor

PR will be opened shortly

@idettman idettman linked a pull request Jun 18, 2020 that will close this issue
1 task
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 2, 2020
@stale stale bot closed this as completed Jul 11, 2020
@josepowera
Copy link

PR-7773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants