Set cookie domain in pubcid / userid on main domain, not subdomain #5395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
� Conflicts: � package.json
added 6 commits
June 18, 2020 10:01
…into update-userid-setcookie-domain
…into update-userid-setcookie-domain # Conflicts: # test/spec/modules/userId_spec.js
idettman
force-pushed
the
update-userid-setcookie-domain
branch
from
4eb48a9 to
a06a94c
Compare
|
@idettman Can you submit this branch against prebid-4.0 branch |
|
opening PR against the 4.0 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Set cookie domain in pubcid / userid on main domain, not subdomain