Currency module issue with EUR

[nikkoi]

Type of issue

Error caused by the currency module.

Description

We're seeing and error being thrown when updating from Prebid 1.4 to the latest
(2.2) using the currency module. Earlier everything worked as expected, now we see the following error:

Removing this makes the error disappear:

"currency": { "adServerCurrency": "EUR", "granularityMultiplier": 1, "defaultRates": { "USD": { "EUR": 1.13 }} }

Also if I change the adservercurrency to USD, then everything works as expected and no errors are thrown.

Steps to reproduce

Use the latest prebid with currency module, set adservercurrency to EUR

Expected results

No errors.

Actual results

Errors.

[nikkoi]

Tested backwards, and first version where I don't get this is 2.17.0. I assume this has to do with this: #3845 , but can't seem to understand why.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[snapwich]

Is this within a custom analytics adapter? I can't see any obvious issue that would cause that error with the public analytics adapters, but since that commit changed from using a closed over variable to a property on this that error could be caused by calling getCpmInNewCurrency directly or using as a callback somewhere. If that's the case, the calling code should be updated to bind to the bid.

[snapwich]

@nikkoi did this pull-request fix your issue? #3996

[bretg]

@nikkoi - as you pointed out, #3845 was the cause of this -- fixed in 2.18. May we close?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.